[Intel-wired-lan] [PATCH] ethernet: Use dma_zalloc_coherent to replace dma_alloc_coherent + memset

[Intel-wired-lan] [PATCH] ethernet: Use dma_zalloc_coherent to replace dma_alloc_coherent + memset

[Kirsher, Jeffrey T]

Please send ALL patches against drivers I maintain to the Intel-wired-lan at lists.osuosl.org.  Your repeated refusal to do so, makes me think you are trying to circumvent the maintainer (me) and the correct kernel patch process.

Sent from my iPhone

> On Aug 18, 2018, at 08:00, zhong jiang <zhongjiang@huawei.com> wrote:
> 
> dma_zalloc_coherent has implemented the dma_alloc_coherent() + memset (),
> We prefer to dma_zalloc_coherent instead of open-codeing.
> 
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/net/ethernet/intel/ixgb/ixgb_main.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgb/ixgb_main.c b/drivers/net/ethernet/intel/ixgb/ixgb_main.c
> index 43664ad..d3e72d0 100644
> --- a/drivers/net/ethernet/intel/ixgb/ixgb_main.c
> +++ b/drivers/net/ethernet/intel/ixgb/ixgb_main.c
> @@ -771,14 +771,13 @@ static pci_ers_result_t ixgb_io_error_detected (struct pci_dev *pdev,
>    rxdr->size = rxdr->count * sizeof(struct ixgb_rx_desc);
>    rxdr->size = ALIGN(rxdr->size, 4096);
> 
> -    rxdr->desc = dma_alloc_coherent(&pdev->dev, rxdr->size, &rxdr->dma,
> -                    GFP_KERNEL);
> +    rxdr->desc = dma_zalloc_coherent(&pdev->dev, rxdr->size, &rxdr->dma,
> +                     GFP_KERNEL);
> 
>    if (!rxdr->desc) {
>        vfree(rxdr->buffer_info);
>        return -ENOMEM;
>    }
> -    memset(rxdr->desc, 0, rxdr->size);
> 
>    rxdr->next_to_clean = 0;
>    rxdr->next_to_use = 0;
> -- 
> 1.7.12.4
> 

[Intel-wired-lan] [PATCH] ethernet: Use dma_zalloc_coherent to replace dma_alloc_coherent + memset

[zhong jiang]

On 2018/8/19 8:22, Kirsher, Jeffrey T wrote:
> Please send ALL patches against drivers I maintain to the Intel-wired-lan at lists.osuosl.org.  Your repeated refusal to do so, makes me think you are trying to circumvent the maintainer (me) and the correct kernel patch process.
I am sorry to that. :-[     It is my fault that I never want to circumvent the maintainer.  I will notice that for next time.  Thank you for your understanding.

Best wishes,
zhong jiang 
> Sent from my iPhone
>
>> On Aug 18, 2018, at 08:00, zhong jiang <zhongjiang@huawei.com> wrote:
>>
>> dma_zalloc_coherent has implemented the dma_alloc_coherent() + memset (),
>> We prefer to dma_zalloc_coherent instead of open-codeing.
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>> drivers/net/ethernet/intel/ixgb/ixgb_main.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/intel/ixgb/ixgb_main.c b/drivers/net/ethernet/intel/ixgb/ixgb_main.c
>> index 43664ad..d3e72d0 100644
>> --- a/drivers/net/ethernet/intel/ixgb/ixgb_main.c
>> +++ b/drivers/net/ethernet/intel/ixgb/ixgb_main.c
>> @@ -771,14 +771,13 @@ static pci_ers_result_t ixgb_io_error_detected (struct pci_dev *pdev,
>>    rxdr->size = rxdr->count * sizeof(struct ixgb_rx_desc);
>>    rxdr->size = ALIGN(rxdr->size, 4096);
>>
>> -    rxdr->desc = dma_alloc_coherent(&pdev->dev, rxdr->size, &rxdr->dma,
>> -                    GFP_KERNEL);
>> +    rxdr->desc = dma_zalloc_coherent(&pdev->dev, rxdr->size, &rxdr->dma,
>> +                     GFP_KERNEL);
>>
>>    if (!rxdr->desc) {
>>        vfree(rxdr->buffer_info);
>>        return -ENOMEM;
>>    }
>> -    memset(rxdr->desc, 0, rxdr->size);
>>
>>    rxdr->next_to_clean = 0;
>>    rxdr->next_to_use = 0;
>> -- 
>> 1.7.12.4
>>
> .
>