From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: "Zaborska, Olga" <olga.zaborska@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v3 1/3] igb: Change IGB_MIN to allow set rx/tx value between 64 and 80
Date: Wed, 19 Jul 2023 10:11:59 -0700 [thread overview]
Message-ID: <6288bd96-8de9-b17d-2c7d-fd29715600fa@intel.com> (raw)
In-Reply-To: <20230717105812.298188-2-olga.zaborska@intel.com>
On 7/17/2023 3:58 AM, Zaborska, Olga wrote:
Please check your gitconfig settings (and fix the author)
WARNING: From:/Signed-off-by: email name mismatch: 'From: "Zaborska,
Olga" <olga.zaborska@intel.com>' != 'Signed-off-by: Olga Zaborska
<olga.zaborska@intel.com>'
> Change the minimum value of RX/TX descriptors to 64 to
> enable setting the rx/tx value between 64 and 80. All igb devices can use as
> low as 64 descriptors. This change will unify igb with other drivers. Based
> on commit 7b1be19 ("e1000e: lower ring minimum size to 64")
>
> Fixes: 0507ef8 ("igb: Fix code comments and whitespace")
Please reference commits using 12 chars (this and the one in the commit
message - directly above this)
"WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1>
("<title line>")'"
These apply to all the patches in the series...
additionally, for this one, please use the Fixes that actually caused
the problem, not one the last one that touched the code.
> Signed-off-by: Olga Zaborska <olga.zaborska@intel.com>
> ---
> v1->v2 fixed commit title and message
> v2->v3 fixed commit title and message, added changes for igb and igc
> ---
> drivers/net/ethernet/intel/igb/igb.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igb/igb.h b/drivers/net/ethernet/intel/igb/igb.h
> index 015b78144114..a2b759531cb7 100644
> --- a/drivers/net/ethernet/intel/igb/igb.h
> +++ b/drivers/net/ethernet/intel/igb/igb.h
> @@ -34,11 +34,11 @@ struct igb_adapter;
> /* TX/RX descriptor defines */
> #define IGB_DEFAULT_TXD 256
> #define IGB_DEFAULT_TX_WORK 128
> -#define IGB_MIN_TXD 80
> +#define IGB_MIN_TXD 64
> #define IGB_MAX_TXD 4096
>
> #define IGB_DEFAULT_RXD 256
> -#define IGB_MIN_RXD 80
> +#define IGB_MIN_RXD 64
> #define IGB_MAX_RXD 4096
>
> #define IGB_DEFAULT_ITR 3 /* dynamic */
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-07-19 17:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 10:58 [Intel-wired-lan] [PATCH iwl-net v3 0/3] Change MIN_TXD and MIN_RXD to allow set rx/tx value between 64 and 80 Zaborska, Olga
2023-07-17 10:58 ` [Intel-wired-lan] [PATCH iwl-net v3 1/3] igb: Change IGB_MIN " Zaborska, Olga
2023-07-19 17:11 ` Tony Nguyen [this message]
2023-07-17 10:58 ` [Intel-wired-lan] [PATCH iwl-net v3 2/3] igbvf: Change IGBVF_MIN " Zaborska, Olga
2023-07-17 10:58 ` Zaborska, Olga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6288bd96-8de9-b17d-2c7d-fd29715600fa@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=olga.zaborska@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox