* [Intel-wired-lan] [PATCH iwl-net v3 0/3] Change MIN_TXD and MIN_RXD to allow set rx/tx value between 64 and 80
@ 2023-07-17 10:58 Zaborska, Olga
2023-07-17 10:58 ` [Intel-wired-lan] [PATCH iwl-net v3 1/3] igb: Change IGB_MIN " Zaborska, Olga
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Zaborska, Olga @ 2023-07-17 10:58 UTC (permalink / raw)
To: intel-wired-lan; +Cc: Zaborska, Olga
Change the minimum value of RX/TX descriptors to 64 to enabl'e setting the rx/tx value
between 64 and 80. All igb, igbf and igc devices can use as low as 64 descriptors.
Olga Zaborska (1):
igbvf: Change IGBVF_MIN to allow set rx/tx value between 64 and 80
Zaborska, Olga (2):
igb: Change IGB_MIN to allow set rx/tx value between 64 and 80 Change
the minimum value of RX/TX descriptors to 64 to enable setting the
rx/tx value between 64 and 80. All igb devices can use as low as 64
descriptors. This change will unify igb with other drivers. Based on
commit 7b1be19 ("e1000e: lower ring minimum size to 64")
igc: Change IGC_MIN to allow set rx/tx value between 64 and 80
drivers/net/ethernet/intel/igb/igb.h | 4 ++--
drivers/net/ethernet/intel/igbvf/igbvf.h | 4 ++--
drivers/net/ethernet/intel/igc/igc.h | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
--
2.31.1
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 5+ messages in thread* [Intel-wired-lan] [PATCH iwl-net v3 1/3] igb: Change IGB_MIN to allow set rx/tx value between 64 and 80
2023-07-17 10:58 [Intel-wired-lan] [PATCH iwl-net v3 0/3] Change MIN_TXD and MIN_RXD to allow set rx/tx value between 64 and 80 Zaborska, Olga
@ 2023-07-17 10:58 ` Zaborska, Olga
2023-07-19 17:11 ` Tony Nguyen
2023-07-17 10:58 ` [Intel-wired-lan] [PATCH iwl-net v3 2/3] igbvf: Change IGBVF_MIN " Zaborska, Olga
2023-07-17 10:58 ` Zaborska, Olga
2 siblings, 1 reply; 5+ messages in thread
From: Zaborska, Olga @ 2023-07-17 10:58 UTC (permalink / raw)
To: intel-wired-lan; +Cc: Zaborska, Olga
Change the minimum value of RX/TX descriptors to 64 to
enable setting the rx/tx value between 64 and 80. All igb devices can use as
low as 64 descriptors. This change will unify igb with other drivers. Based
on commit 7b1be19 ("e1000e: lower ring minimum size to 64")
Fixes: 0507ef8 ("igb: Fix code comments and whitespace")
Signed-off-by: Olga Zaborska <olga.zaborska@intel.com>
---
v1->v2 fixed commit title and message
v2->v3 fixed commit title and message, added changes for igb and igc
---
drivers/net/ethernet/intel/igb/igb.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/igb.h b/drivers/net/ethernet/intel/igb/igb.h
index 015b78144114..a2b759531cb7 100644
--- a/drivers/net/ethernet/intel/igb/igb.h
+++ b/drivers/net/ethernet/intel/igb/igb.h
@@ -34,11 +34,11 @@ struct igb_adapter;
/* TX/RX descriptor defines */
#define IGB_DEFAULT_TXD 256
#define IGB_DEFAULT_TX_WORK 128
-#define IGB_MIN_TXD 80
+#define IGB_MIN_TXD 64
#define IGB_MAX_TXD 4096
#define IGB_DEFAULT_RXD 256
-#define IGB_MIN_RXD 80
+#define IGB_MIN_RXD 64
#define IGB_MAX_RXD 4096
#define IGB_DEFAULT_ITR 3 /* dynamic */
--
2.31.1
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Intel-wired-lan] [PATCH iwl-net v3 1/3] igb: Change IGB_MIN to allow set rx/tx value between 64 and 80
2023-07-17 10:58 ` [Intel-wired-lan] [PATCH iwl-net v3 1/3] igb: Change IGB_MIN " Zaborska, Olga
@ 2023-07-19 17:11 ` Tony Nguyen
0 siblings, 0 replies; 5+ messages in thread
From: Tony Nguyen @ 2023-07-19 17:11 UTC (permalink / raw)
To: Zaborska, Olga, intel-wired-lan
On 7/17/2023 3:58 AM, Zaborska, Olga wrote:
Please check your gitconfig settings (and fix the author)
WARNING: From:/Signed-off-by: email name mismatch: 'From: "Zaborska,
Olga" <olga.zaborska@intel.com>' != 'Signed-off-by: Olga Zaborska
<olga.zaborska@intel.com>'
> Change the minimum value of RX/TX descriptors to 64 to
> enable setting the rx/tx value between 64 and 80. All igb devices can use as
> low as 64 descriptors. This change will unify igb with other drivers. Based
> on commit 7b1be19 ("e1000e: lower ring minimum size to 64")
>
> Fixes: 0507ef8 ("igb: Fix code comments and whitespace")
Please reference commits using 12 chars (this and the one in the commit
message - directly above this)
"WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1>
("<title line>")'"
These apply to all the patches in the series...
additionally, for this one, please use the Fixes that actually caused
the problem, not one the last one that touched the code.
> Signed-off-by: Olga Zaborska <olga.zaborska@intel.com>
> ---
> v1->v2 fixed commit title and message
> v2->v3 fixed commit title and message, added changes for igb and igc
> ---
> drivers/net/ethernet/intel/igb/igb.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igb/igb.h b/drivers/net/ethernet/intel/igb/igb.h
> index 015b78144114..a2b759531cb7 100644
> --- a/drivers/net/ethernet/intel/igb/igb.h
> +++ b/drivers/net/ethernet/intel/igb/igb.h
> @@ -34,11 +34,11 @@ struct igb_adapter;
> /* TX/RX descriptor defines */
> #define IGB_DEFAULT_TXD 256
> #define IGB_DEFAULT_TX_WORK 128
> -#define IGB_MIN_TXD 80
> +#define IGB_MIN_TXD 64
> #define IGB_MAX_TXD 4096
>
> #define IGB_DEFAULT_RXD 256
> -#define IGB_MIN_RXD 80
> +#define IGB_MIN_RXD 64
> #define IGB_MAX_RXD 4096
>
> #define IGB_DEFAULT_ITR 3 /* dynamic */
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-wired-lan] [PATCH iwl-net v3 2/3] igbvf: Change IGBVF_MIN to allow set rx/tx value between 64 and 80
2023-07-17 10:58 [Intel-wired-lan] [PATCH iwl-net v3 0/3] Change MIN_TXD and MIN_RXD to allow set rx/tx value between 64 and 80 Zaborska, Olga
2023-07-17 10:58 ` [Intel-wired-lan] [PATCH iwl-net v3 1/3] igb: Change IGB_MIN " Zaborska, Olga
@ 2023-07-17 10:58 ` Zaborska, Olga
2023-07-17 10:58 ` Zaborska, Olga
2 siblings, 0 replies; 5+ messages in thread
From: Zaborska, Olga @ 2023-07-17 10:58 UTC (permalink / raw)
To: intel-wired-lan; +Cc: Olga Zaborska
From: Olga Zaborska <olga.zaborska@intel.com>
Change the minimum value of RX/TX descriptors to 64 to enable setting the rx/tx value
between 64 and 80. All igbvf devices can use as low as 64 descriptors.
This change will unify igbvf with other drivers.
Based on commit 7b1be19 ("e1000e: lower ring minimum size to 64")
Fixes: d4e0fe0 ("igbvf: add new driver to support 82576 virtual functions")
Signed-off-by: Olga Zaborska <olga.zaborska@intel.com>
---
v1->v2 fixed commit title and message
v2->v3 fixed commit title and message, added changes for igb and igc
---
drivers/net/ethernet/intel/igbvf/igbvf.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igbvf/igbvf.h b/drivers/net/ethernet/intel/igbvf/igbvf.h
index 57d39ee00b58..7b83678ba83a 100644
--- a/drivers/net/ethernet/intel/igbvf/igbvf.h
+++ b/drivers/net/ethernet/intel/igbvf/igbvf.h
@@ -39,11 +39,11 @@ enum latency_range {
/* Tx/Rx descriptor defines */
#define IGBVF_DEFAULT_TXD 256
#define IGBVF_MAX_TXD 4096
-#define IGBVF_MIN_TXD 80
+#define IGBVF_MIN_TXD 64
#define IGBVF_DEFAULT_RXD 256
#define IGBVF_MAX_RXD 4096
-#define IGBVF_MIN_RXD 80
+#define IGBVF_MIN_RXD 64
#define IGBVF_MIN_ITR_USECS 10 /* 100000 irq/sec */
#define IGBVF_MAX_ITR_USECS 10000 /* 100 irq/sec */
--
2.31.1
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Intel-wired-lan] [PATCH iwl-net v3 2/3] igbvf: Change IGBVF_MIN to allow set rx/tx value between 64 and 80
2023-07-17 10:58 [Intel-wired-lan] [PATCH iwl-net v3 0/3] Change MIN_TXD and MIN_RXD to allow set rx/tx value between 64 and 80 Zaborska, Olga
2023-07-17 10:58 ` [Intel-wired-lan] [PATCH iwl-net v3 1/3] igb: Change IGB_MIN " Zaborska, Olga
2023-07-17 10:58 ` [Intel-wired-lan] [PATCH iwl-net v3 2/3] igbvf: Change IGBVF_MIN " Zaborska, Olga
@ 2023-07-17 10:58 ` Zaborska, Olga
2 siblings, 0 replies; 5+ messages in thread
From: Zaborska, Olga @ 2023-07-17 10:58 UTC (permalink / raw)
To: intel-wired-lan; +Cc: Olga Zaborska
From: Olga Zaborska <olga.zaborska@intel.com>
Change the minimum value of RX/TX descriptors to 64 to enable setting the rx/tx value
between 64 and 80. All igbvf devices can use as low as 64 descriptors.
This change will unify igbvf with other drivers.
Based on commit 7b1be19 ("e1000e: lower ring minimum size to 64")
Fixes: d4e0fe0 ("igbvf: add new driver to support 82576 virtual functions")
Signed-off-by: Olga Zaborska <olga.zaborska@intel.com>
---
v1->v2 fixed commit title and message
v2->v3 fixed commit title and message, added changes for igb and igc
---
drivers/net/ethernet/intel/igbvf/igbvf.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igbvf/igbvf.h b/drivers/net/ethernet/intel/igbvf/igbvf.h
index 57d39ee00b58..7b83678ba83a 100644
--- a/drivers/net/ethernet/intel/igbvf/igbvf.h
+++ b/drivers/net/ethernet/intel/igbvf/igbvf.h
@@ -39,11 +39,11 @@ enum latency_range {
/* Tx/Rx descriptor defines */
#define IGBVF_DEFAULT_TXD 256
#define IGBVF_MAX_TXD 4096
-#define IGBVF_MIN_TXD 80
+#define IGBVF_MIN_TXD 64
#define IGBVF_DEFAULT_RXD 256
#define IGBVF_MAX_RXD 4096
-#define IGBVF_MIN_RXD 80
+#define IGBVF_MIN_RXD 64
#define IGBVF_MIN_ITR_USECS 10 /* 100000 irq/sec */
#define IGBVF_MAX_ITR_USECS 10000 /* 100 irq/sec */
--
2.31.1
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-19 17:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-17 10:58 [Intel-wired-lan] [PATCH iwl-net v3 0/3] Change MIN_TXD and MIN_RXD to allow set rx/tx value between 64 and 80 Zaborska, Olga
2023-07-17 10:58 ` [Intel-wired-lan] [PATCH iwl-net v3 1/3] igb: Change IGB_MIN " Zaborska, Olga
2023-07-19 17:11 ` Tony Nguyen
2023-07-17 10:58 ` [Intel-wired-lan] [PATCH iwl-net v3 2/3] igbvf: Change IGBVF_MIN " Zaborska, Olga
2023-07-17 10:58 ` Zaborska, Olga
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox