From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Cc: anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org,
Jedrzej Jagielski <jedrzej.jagielski@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2] i40e: add restore default speed when changed PHY doesn't support it
Date: Wed, 11 Oct 2023 11:24:56 +0200 [thread overview]
Message-ID: <68683434-4241-4726-9028-96368815b7dc@intel.com> (raw)
In-Reply-To: <4ab9d2c8-05bc-40f2-90d5-303aacdca5e2@intel.com>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Date: Wed, 11 Oct 2023 11:22:21 +0200
> From: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> Date: Wed, 11 Oct 2023 11:13:42 +0200
>
> Please add netdev and linux-kernel MLs to CCs when sending the next version.
>
>> In order to avoid no link after plugging a different type PHY module.
>
> The sentence is incomplete, it tells "why", but no "what".
>
>>
>> Add reset link speed settings to the default values for PHY module,
>> if different PHY module is inserted and currently defined user-specified
>> speed is not compatible with this module.
>>
>> Reviewed-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
>> Signed-off-by: Radoslaw Tyl <radoslawx.tyl@intel.com>
>
> How did Radoslaw participate?
> If he's the author, he must be in the "From" field as well. If not, his
> SoB tells me nothing. Author, co-developer, reviewer, ...?
Also, his email address bounces, IOW there's no point in adding this
SoB. If you want to credit his work, use his working email, either
private or dunno, otherwise makes no sense.
>
>> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
[...]
Thanks,
Olek
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-10-11 9:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 9:13 [Intel-wired-lan] [PATCH iwl-next v2] i40e: add restore default speed when changed PHY doesn't support it Aleksandr Loktionov
2023-10-11 9:22 ` Alexander Lobakin
2023-10-11 9:24 ` Alexander Lobakin [this message]
2023-10-11 10:32 ` Loktionov, Aleksandr
2023-10-12 16:00 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68683434-4241-4726-9028-96368815b7dc@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jedrzej.jagielski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox