Re: [Intel-wired-lan] [PATCH iwl-next v2] i40e: add restore default speed when changed PHY doesn't support it

[Alexander Lobakin <aleksander.lobakin@intel.com>]

From: Loktionov, Aleksandr <aleksandr.loktionov@intel.com>
Date: Wed, 11 Oct 2023 12:32:25 +0200

> 
> 
>> -----Original Message-----
>> From: Lobakin, Aleksander <aleksander.lobakin@intel.com>
>> Sent: Wednesday, October 11, 2023 11:25 AM
>> To: Loktionov, Aleksandr <aleksandr.loktionov@intel.com>
>> Cc: intel-wired-lan@lists.osuosl.org; Nguyen, Anthony L
>> <anthony.l.nguyen@intel.com>; Jagielski, Jedrzej <jedrzej.jagielski@intel.com>
>> Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2] i40e: add restore default speed
>> when changed PHY doesn't support it
>>
>> From: Alexander Lobakin <aleksander.lobakin@intel.com>
>> Date: Wed, 11 Oct 2023 11:22:21 +0200
>>
>>> From: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
>>> Date: Wed, 11 Oct 2023 11:13:42 +0200
>>>
>>> Please add netdev and linux-kernel MLs to CCs when sending the next version.
> Sure will do it in next version, thank you for the note
> 
>>>
>>>> In order to avoid no link after plugging a different type PHY module.
>>>
>>> The sentence is incomplete, it tells "why", but no "what".
> Please clarify your suggestion, what is your "what" expectations?

Usually, "in order" is only the first part of a sentence.
Like,

"In order to reply to your message, I need to click "Reply All".".

But you say something like

"In order to reply to your message."

and that's it. And I don't get what you wanted to say here, as the
second part is missing.

> 
>>>
>>>>
>>>> Add reset link speed settings to the default values for PHY module,
>>>> if different PHY module is inserted and currently defined
>>>> user-specified speed is not compatible with this module.
>>>>
>>>> Reviewed-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
>>>> Signed-off-by: Radoslaw Tyl <radoslawx.tyl@intel.com>
>>>
>>> How did Radoslaw participate?
>>> If he's the author, he must be in the "From" field as well. If not,
>>> his SoB tells me nothing. Author, co-developer, reviewer, ...?
>>
>> Also, his email address bounces, IOW there's no point in adding this SoB. If you
>> want to credit his work, use his working email, either private or dunno,
>> otherwise makes no sense.
> Can you explain what do you mean by 'IOW'?

"In Other Words" -- IOW.

> 
> Radek is original author of the patch for OOT driver which a had re-work to be accepted for upstream. Now he is no longer works in Intel. I wanted to give him a credit. What do you suggest?

There's no point in specifying non-working email addresses.
If you want to credit him, pick his personal email or his new work email
or whatever works and allows to contact with him.

The fact that he's the original author implies he should be the author
of the commit as well, but you send it as if you was the author.
`git commit --author='Radoslaw ...'`

> 
>>>
>>>> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
>>
>> [...]
>>
>> Thanks,
>> Olek

Thanks,
Olek
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan