[Intel-wired-lan] [PATCH net v4] ice: Fix VSI configuration for non-PF network devices

[Intel-wired-lan] [PATCH net v4] ice: Fix VSI configuration for non-PF network devices

[Benjamin Mikailenko]

This fixes an issue for a failing loopback test
"ethtool -t offline ethx". Do not set Rx mode
and VSI VLAN for non-PF network devices.

Fixes: c7f2c42b80ed ("ice: Fix a few null pointer dereference issues")
Signed-off-by: Benjamin Mikailenko <benjamin.mikailenko@intel.com>
---
 drivers/net/ethernet/intel/ice/ice_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index 752bd8a10495..e4ae67da5b77 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -6010,7 +6010,7 @@ int ice_vsi_cfg(struct ice_vsi *vsi)
 {
 	int err;
 
-	if (vsi->netdev) {
+	if (vsi->netdev && vsi->type == ICE_VSI_PF) {
 		ice_set_rx_mode(vsi->netdev);
 
 		err = ice_vsi_vlan_setup(vsi);
-- 
2.34.3

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Re: [Intel-wired-lan] [PATCH net v4] ice: Fix VSI configuration for non-PF network devices

[Tony Nguyen]

On 7/12/2022 8:14 AM, Benjamin Mikailenko wrote:
> This fixes an issue for a failing loopback test
> "ethtool -t offline ethx". Do not set Rx mode
> and VSI VLAN for non-PF network devices.

This sounds very much like this patch/issue [1]. Can you test that and 
see if it fixes this issue.

> Fixes: c7f2c42b80ed ("ice: Fix a few null pointer dereference issues")
> Signed-off-by: Benjamin Mikailenko <benjamin.mikailenko@intel.com>

[1] 
https://lore.kernel.org/intel-wired-lan/20220707102044.48775-3-maciej.fijalkowski@intel.com/T/#u
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Re: [Intel-wired-lan] [PATCH net v4] ice: Fix VSI configuration for non-PF network devices

[Benjamin Mikailenko]

On 7/14/2022 1:50 PM, Tony Nguyen wrote:
> 
> 
> On 7/12/2022 8:14 AM, Benjamin Mikailenko wrote:
>> This fixes an issue for a failing loopback test
>> "ethtool -t offline ethx". Do not set Rx mode
>> and VSI VLAN for non-PF network devices.
> 
> This sounds very much like this patch/issue [1]. Can you test that and see if it fixes this issue.

Yes, issue is fixed. Tested on current next-queue dev-queue.

> 
>> Fixes: c7f2c42b80ed ("ice: Fix a few null pointer dereference issues")
>> Signed-off-by: Benjamin Mikailenko <benjamin.mikailenko@intel.com>
> 
> [1] https://lore.kernel.org/intel-wired-lan/20220707102044.48775-3-maciej.fijalkowski@intel.com/T/#u
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Re: [Intel-wired-lan] [PATCH net v4] ice: Fix VSI configuration for non-PF network devices

[Tony Nguyen]

On 7/14/2022 2:11 PM, Benjamin Mikailenko wrote:
> 
> 
> On 7/14/2022 1:50 PM, Tony Nguyen wrote:
>>
>>
>> On 7/12/2022 8:14 AM, Benjamin Mikailenko wrote:
>>> This fixes an issue for a failing loopback test
>>> "ethtool -t offline ethx". Do not set Rx mode
>>> and VSI VLAN for non-PF network devices.
>>
>> This sounds very much like this patch/issue [1]. Can you test that and see if it fixes this issue.
> 
> Yes, issue is fixed. Tested on current next-queue dev-queue.

Thanks for the quick check. I'll keep the existing patch and not use 
this one then.

>>
>>> Fixes: c7f2c42b80ed ("ice: Fix a few null pointer dereference issues")
>>> Signed-off-by: Benjamin Mikailenko <benjamin.mikailenko@intel.com>
>>
>> [1] https://lore.kernel.org/intel-wired-lan/20220707102044.48775-3-maciej.fijalkowski@intel.com/T/#u
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan