From: Thomas Gleixner <tglx@linutronix.de>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH tip:irq/core v1] genirq: remove auto-set of the mask when setting the hint
Date: Mon, 17 May 2021 21:47:12 +0200 [thread overview]
Message-ID: <87y2cddtxb.ffs@nanos.tec.linutronix.de> (raw)
In-Reply-To: <CAFki+L=LDizBJmFUieMDg9J=U6mn6XxTPPkAaWiyppTouTzaqw@mail.gmail.com>
Nitesh,
On Mon, May 17 2021 at 14:21, Nitesh Lal wrote:
> On Mon, May 17, 2021 at 1:26 PM Robin Murphy <robin.murphy@arm.com> wrote:
>
> We can use irq_set_affinity() to set the hint mask as well, however, maybe
> there is a specific reason behind separating those two in the
> first place (maybe not?).
Yes, because kernel side settings might overwrite the hint.
> But even in this case, we have to either modify the PMU drivers' IRQs
> affinity from the userspace or we will have to make changes in the existing
> request_irq code path.
Adjusting them from user space does not work for various reasons,
especially CPU hotplug.
> I am not sure about the latter because we already have the required controls
> to adjust the device IRQ mask (by using default_smp_affinity or by modifying
> them manually).
default_smp_affinity does not help at all and there is nothing a module
can modify manually.
I'll send out a patch series which cleans that up soon.
Thanks,
tglx
next prev parent reply other threads:[~2021-05-17 19:47 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-01 2:18 [Intel-wired-lan] [PATCH tip:irq/core v1] genirq: remove auto-set of the mask when setting the hint Jesse Brandeburg
2021-05-04 12:15 ` Robin Murphy
2021-05-04 14:29 ` Nitesh Lal
2021-05-04 16:23 ` Jesse Brandeburg
2021-05-17 16:57 ` Nitesh Lal
2021-05-17 17:26 ` Robin Murphy
2021-05-17 18:08 ` Thomas Gleixner
2021-05-17 18:50 ` Robin Murphy
2021-05-17 19:08 ` Thomas Gleixner
2021-05-17 19:43 ` Thomas Gleixner
2021-05-17 20:18 ` Thomas Gleixner
2021-05-17 18:21 ` Nitesh Lal
2021-05-17 19:47 ` Thomas Gleixner [this message]
2021-05-17 21:13 ` Nitesh Lal
2021-05-17 20:48 ` Thomas Gleixner
2021-05-17 22:44 ` Nitesh Lal
2021-05-18 0:03 ` Thomas Gleixner
2021-05-18 0:23 ` Nitesh Lal
2021-05-20 21:57 ` Nitesh Lal
2021-05-21 0:03 ` Nitesh Lal
2021-05-21 11:56 ` Thomas Gleixner
2021-05-21 12:03 ` [Intel-wired-lan] [PATCH] genirq: Provide new interfaces for affinity hints Thomas Gleixner
2021-05-21 15:45 ` Lijun Pan
2021-05-21 21:45 ` Thomas Gleixner
2021-05-21 16:13 ` Nitesh Lal
2021-05-21 21:48 ` Thomas Gleixner
2021-06-04 20:35 ` Nitesh Lal
2021-05-27 10:03 ` Shung-Hsi Yu
2021-05-27 10:21 ` Shung-Hsi Yu
2021-05-27 13:06 ` Nitesh Lal
2021-05-28 7:20 ` Shung-Hsi Yu
2021-06-07 17:00 ` Nitesh Lal
2021-06-14 16:12 ` Nitesh Lal
2021-05-21 13:46 ` [Intel-wired-lan] [PATCH tip:irq/core v1] genirq: remove auto-set of the mask when setting the hint Nitesh Lal
2021-05-21 15:15 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2cddtxb.ffs@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox