Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Lifshits, Vitaly" <vitaly.lifshits@intel.com>
To: Vlad URSU <vlad@ursu.me>, Jacek Kowalski <jacek@jacekk.info>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	 Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	 Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>
Cc: <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH] e1000e: disregard NVM checksum on tgp when valid checksum mask is not set
Date: Sun, 1 Jun 2025 13:19:22 +0300	[thread overview]
Message-ID: <8adbc5a0-782d-4a07-93d7-c64ae0e3d805@intel.com> (raw)
In-Reply-To: <47b2fe98-da85-4cef-9668-51c36ac66ce5@ursu.me>



On 5/15/2025 10:07 PM, Vlad URSU wrote:
> On 15.05.2025 07:39, Lifshits, Vitaly wrote:
>> Since the checksum word is 0xFFFF which is peculiar, can you dump the 
>> whole NVM and share with us?
> 
> Sure, here's a dump of my NVM
> 
> Offset        Values
> ------        ------
> 0x0000:        d0 8e 79 07 78 c8 01 08 ff ff 44 00 01 00 6c 00
> 0x0010:        ff ff ff ff c9 10 54 0a 28 10 f9 15 00 00 00 00
> 0x0020:        00 00 00 00 00 80 05 a7 30 30 00 16 00 00 00 0c
> 0x0030:        f3 08 00 0a 43 08 13 01 f9 15 ad ba f9 15 fa 15
> 0x0040:        ad ba f9 15 ad ba f9 15 00 00 80 80 00 4e 86 08

You're right — I see that the SW compatibility bit is set and the 
checksum appears to be incorrect.

Since the NVM is part of the system firmware and typically managed by 
the system manufacturer, I recommend checking whether a firmware update 
is available for your system as a first step.

If no update is available, perhaps we can consider ignoring the checksum 
on TGP systems if one of the following conditions is met:
1. SW compatibility bit is not set (current Jacek's approach)
2. The checksum word at offset 0x3F retains its factory default value of 
0xFFFF.

  reply	other threads:[~2025-06-01 10:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-22  7:43 [Intel-wired-lan] [PATCH] e1000e: disregard NVM checksum on tgp when valid checksum mask is not set Jacek Kowalski
2025-04-22  8:39 ` Lifshits, Vitaly
2025-04-24 16:24 ` Simon Horman
2025-04-24 16:46   ` Jacek Kowalski
2025-04-24 17:18     ` Simon Horman
2025-04-24 17:37       ` Jacek Kowalski
2025-04-25 16:45         ` Simon Horman
2025-04-24 16:59   ` Lifshits, Vitaly
2025-04-24 17:29     ` Jacek Kowalski
2025-04-27 13:26       ` Lifshits, Vitaly
2025-04-28 16:43         ` Jacek Kowalski
2025-05-04  9:13           ` Lifshits, Vitaly
2025-05-12 17:25 ` Vlad URSU
2025-05-15  4:39   ` Lifshits, Vitaly
2025-05-15 19:07     ` Vlad URSU
2025-06-01 10:19       ` Lifshits, Vitaly [this message]
2025-06-02 18:44         ` Vlad URSU
2025-06-03  9:22           ` Lifshits, Vitaly
2025-06-03 21:00             ` Jacek Kowalski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8adbc5a0-782d-4a07-93d7-c64ae0e3d805@intel.com \
    --to=vitaly.lifshits@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jacek@jacekk.info \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=vlad@ursu.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox