From: "Lifshits, Vitaly" <vitaly.lifshits@intel.com>
To: Jacek Kowalski <jacek@jacekk.info>, Simon Horman <horms@kernel.org>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH] e1000e: disregard NVM checksum on tgp when valid checksum mask is not set
Date: Sun, 4 May 2025 12:13:44 +0300 [thread overview]
Message-ID: <c890cd3b-a4c5-217d-3ad3-6d9389b98f7c@intel.com> (raw)
In-Reply-To: <a0069d48-38b9-4bf0-979f-7051f8e906f4@jacekk.info>
On 4/28/2025 7:43 PM, Jacek Kowalski wrote:
>> Anyway, I think that the commit message should be precise.
>> How about this?
>>
>> Starting from Tiger Lake, LAN NVM is locked for writes by SW, so the
>> driver cannot perform checksum validation and correction. This means
>> that all NVM images must leave the factory with correct checksum and
>> checksum valid bit set. Since Tiger Lake devices were the first to
>> have this lock, some systems in the field did not meet this
>> requirement. Therefore, for these transitional devices we skip
>> checksum update and verification, if the valid bit is not set.
>
> Should I prepare v2 with this description?
>
Yes, please.
next prev parent reply other threads:[~2025-05-04 9:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 7:43 [Intel-wired-lan] [PATCH] e1000e: disregard NVM checksum on tgp when valid checksum mask is not set Jacek Kowalski
2025-04-22 8:39 ` Lifshits, Vitaly
2025-04-24 16:24 ` Simon Horman
2025-04-24 16:46 ` Jacek Kowalski
2025-04-24 17:18 ` Simon Horman
2025-04-24 17:37 ` Jacek Kowalski
2025-04-25 16:45 ` Simon Horman
2025-04-24 16:59 ` Lifshits, Vitaly
2025-04-24 17:29 ` Jacek Kowalski
2025-04-27 13:26 ` Lifshits, Vitaly
2025-04-28 16:43 ` Jacek Kowalski
2025-05-04 9:13 ` Lifshits, Vitaly [this message]
2025-05-12 17:25 ` Vlad URSU
2025-05-15 4:39 ` Lifshits, Vitaly
2025-05-15 19:07 ` Vlad URSU
2025-06-01 10:19 ` Lifshits, Vitaly
2025-06-02 18:44 ` Vlad URSU
2025-06-03 9:22 ` Lifshits, Vitaly
2025-06-03 21:00 ` Jacek Kowalski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c890cd3b-a4c5-217d-3ad3-6d9389b98f7c@intel.com \
--to=vitaly.lifshits@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacek@jacekk.info \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox