From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Sasha Neftin <sasha.neftin@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2 1/1] igc: Fix the typo in the PTM Control macro
Date: Fri, 4 Aug 2023 14:39:45 -0700 [thread overview]
Message-ID: <9c6e83fe-7bca-6332-ef71-19e0bb59447d@intel.com> (raw)
In-Reply-To: <20230803023758.3916368-1-sasha.neftin@intel.com>
On 8/2/2023 7:37 PM, Sasha Neftin wrote:
> The IGC_PTM_CTRL_SHRT_CYC defines the time between two consecutive PTM
> requests. The bit resolution of this field is six bits. That bit five was
> missing in the mask. This patch comes to correct the typo in the
> IGC_PTM_CTRL_SHRT_CYC macro.
This doesn't apply
> Fixes: a90ec8483732 ("igc: Add support for PTP getcrosststamp()")
> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
> ---
> v1->v2: Fixed commit message
> ---
> drivers/net/ethernet/intel/igc/igc_defines.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_defines.h b/drivers/net/ethernet/intel/igc/igc_defines.h
> index c3722f524ea7..0bac6eeb42c0 100644
> --- a/drivers/net/ethernet/intel/igc/igc_defines.h
> +++ b/drivers/net/ethernet/intel/igc/igc_defines.h
> @@ -546,7 +546,7 @@
> #define IGC_PTM_CTRL_START_NOW BIT(29) /* Start PTM Now */
> #define IGC_PTM_CTRL_EN BIT(30) /* Enable PTM */
> #define IGC_PTM_CTRL_TRIG BIT(31) /* PTM Cycle trigger */
> -#define IGC_PTM_CTRL_SHRT_CYC(usec) (((usec) & 0x2f) << 2)
> +#define IGC_PTM_CTRL_SHRT_CYC(usec) (((usec) & 0x3f) << 2)
> #define IGC_PTM_CTRL_PTM_TO(usec) (((usec) & 0xff) << 8)
>
> #define IGC_PTM_SHORT_CYC_DEFAULT 1 /* Default short cycle interval */
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-08-04 21:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 2:37 [Intel-wired-lan] [PATCH iwl-net v2 1/1] igc: Fix the typo in the PTM Control macro Sasha Neftin
2023-08-04 21:39 ` Tony Nguyen [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-08-08 4:23 Sasha Neftin
2023-08-21 7:38 ` naamax.meir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c6e83fe-7bca-6332-ef71-19e0bb59447d@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=sasha.neftin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox