From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next v1 3/5] devlink: Allow set specific ops callbacks dynamically
Date: Wed, 29 Sep 2021 14:25:00 +0200 [thread overview]
Message-ID: <YVRbHMODzcciHa2p@kroah.com> (raw)
In-Reply-To: <aac64d4861d6207a90a6d45245ee5ed59114659a.1632916329.git.leonro@nvidia.com>
On Wed, Sep 29, 2021 at 03:00:44PM +0300, Leon Romanovsky wrote:
> +void devlink_set_ops(struct devlink *devlink, struct devlink_ops *ops)
> +{
> + struct devlink_ops *dev_ops = devlink->ops;
> +
> + WARN_ON(!devlink_reload_actions_valid(ops));
> +
> +#define SET_DEVICE_OP(ptr, op, name) \
> + do { \
> + if ((op)->name) \
> + if (!((ptr)->name)) \
> + (ptr)->name = (op)->name; \
> + } while (0)
> +
> + /* Keep sorted */
> + SET_DEVICE_OP(dev_ops, ops, reload_actions);
> + SET_DEVICE_OP(dev_ops, ops, reload_down);
> + SET_DEVICE_OP(dev_ops, ops, reload_limits);
> + SET_DEVICE_OP(dev_ops, ops, reload_up);
Keep sorted in what order? And why?
thanks,
greg k-h
next prev parent reply other threads:[~2021-09-29 12:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 12:00 [Intel-wired-lan] [PATCH net-next v1 0/5] Devlink reload and missed notifications fix Leon Romanovsky
2021-09-29 12:00 ` [Intel-wired-lan] [PATCH net-next v1 1/5] devlink: Add missed notifications iterators Leon Romanovsky
2021-09-29 13:29 ` Vladimir Oltean
2021-09-29 12:00 ` [Intel-wired-lan] [PATCH net-next v1 2/5] devlink: Allow modification of devlink ops Leon Romanovsky
2021-09-29 12:00 ` [Intel-wired-lan] [PATCH net-next v1 3/5] devlink: Allow set specific ops callbacks dynamically Leon Romanovsky
2021-09-29 12:25 ` Greg Kroah-Hartman [this message]
2021-09-29 12:58 ` Leon Romanovsky
2021-09-29 12:00 ` [Intel-wired-lan] [PATCH net-next v1 4/5] net/mlx5: Register separate reload devlink ops for multiport device Leon Romanovsky
2021-09-29 13:55 ` Jakub Kicinski
2021-09-29 14:16 ` Leon Romanovsky
2021-09-29 14:26 ` Jakub Kicinski
2021-09-29 14:31 ` Leon Romanovsky
2021-09-29 14:35 ` Jakub Kicinski
2021-09-29 15:24 ` Leon Romanovsky
2021-09-29 12:00 ` [Intel-wired-lan] [PATCH net-next v1 5/5] devlink: Delete reload enable/disable interface Leon Romanovsky
2021-09-29 13:40 ` [Intel-wired-lan] [PATCH net-next v1 0/5] Devlink reload and missed notifications fix Jakub Kicinski
2021-09-29 13:46 ` Vladimir Oltean
2021-09-29 13:56 ` Jakub Kicinski
2021-09-29 14:20 ` Leon Romanovsky
2021-09-29 14:13 ` Leon Romanovsky
2021-09-29 14:39 ` Jakub Kicinski
2021-09-29 15:31 ` Leon Romanovsky
2021-09-29 17:55 ` Jakub Kicinski
2021-09-29 19:11 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVRbHMODzcciHa2p@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox