From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v1 1/1] igc: Fix BUG: scheduling while atomic: kworker/u64:0/9/0x00000002
Date: Tue, 8 Mar 2022 10:31:41 +0100 [thread overview]
Message-ID: <YicifXBo5S6pSXAj@boxer> (raw)
In-Reply-To: <20220308092422.2971655-1-sasha.neftin@intel.com>
On Tue, Mar 08, 2022 at 11:24:22AM +0200, Sasha Neftin wrote:
> Replace usleep_range() method with udelay() method to allow atomic contects
s/contects/contexts
> in low-level MDIO access functions.
>
> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2014971
I don't have access to that bugzilla, so can I ask to include the splat in
the commit message itself?
> Fixes: 5586838fe9ce ("igc: Add code for PHY support")
> Reported-by: Corinna Vinschen <vinschen@redhat.com>
> Suggested-by: Dima Ruinskiy <dima.ruinskiy@intel.com>
> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc_phy.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_phy.c b/drivers/net/ethernet/intel/igc/igc_phy.c
> index 40dbf4b43234..6961f65d36b9 100644
> --- a/drivers/net/ethernet/intel/igc/igc_phy.c
> +++ b/drivers/net/ethernet/intel/igc/igc_phy.c
> @@ -581,7 +581,7 @@ static s32 igc_read_phy_reg_mdic(struct igc_hw *hw, u32 offset, u16 *data)
> * the lower time out
> */
> for (i = 0; i < IGC_GEN_POLL_TIMEOUT; i++) {
> - usleep_range(500, 1000);
> + udelay(50);
> mdic = rd32(IGC_MDIC);
> if (mdic & IGC_MDIC_READY)
> break;
> @@ -638,7 +638,7 @@ static s32 igc_write_phy_reg_mdic(struct igc_hw *hw, u32 offset, u16 data)
> * the lower time out
> */
> for (i = 0; i < IGC_GEN_POLL_TIMEOUT; i++) {
> - usleep_range(500, 1000);
> + udelay(50);
> mdic = rd32(IGC_MDIC);
> if (mdic & IGC_MDIC_READY)
> break;
> --
> 2.30.2
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2022-03-08 9:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 9:24 [Intel-wired-lan] [PATCH v1 1/1] igc: Fix BUG: scheduling while atomic: kworker/u64:0/9/0x00000002 Sasha Neftin
2022-03-08 9:31 ` Maciej Fijalkowski [this message]
2022-03-08 15:49 ` Corinna Vinschen
2022-03-08 17:34 ` Neftin, Sasha
2022-03-24 10:23 ` naamax.meir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YicifXBo5S6pSXAj@boxer \
--to=maciej.fijalkowski@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox