Re: [Intel-wired-lan] [PATCH iwl-next V2 04/15] ice: add migration init field and helper functions

[Jason Gunthorpe <jgg@ziepe.ca>]

On Wed, Jun 21, 2023 at 09:11:01AM +0000, Lingyu Liu wrote:
> Adds a function to get ice VF device from pci device.
> Adds a field in VF structure to indicate migration init state,
> and functions to init and uninit migration.
> 
> This will be used by ice_vfio_pci driver introduced in coming patches
> from this series.
> 
> Signed-off-by: Lingyu Liu <lingyu.liu@intel.com>
> Signed-off-by: Yahui Cao <yahui.cao@intel.com>
> ---
>  drivers/net/ethernet/intel/ice/Makefile       |  1 +
>  drivers/net/ethernet/intel/ice/ice.h          |  1 +
>  .../net/ethernet/intel/ice/ice_migration.c    | 68 +++++++++++++++++++
>  drivers/net/ethernet/intel/ice/ice_vf_lib.c   |  7 ++
>  drivers/net/ethernet/intel/ice/ice_vf_lib.h   |  1 +
>  include/linux/net/intel/ice_migration.h       | 26 +++++++
>  6 files changed, 104 insertions(+)
>  create mode 100644 drivers/net/ethernet/intel/ice/ice_migration.c
>  create mode 100644 include/linux/net/intel/ice_migration.h
> 
> diff --git a/drivers/net/ethernet/intel/ice/Makefile b/drivers/net/ethernet/intel/ice/Makefile
> index 960277d78e09..915b70588f79 100644
> --- a/drivers/net/ethernet/intel/ice/Makefile
> +++ b/drivers/net/ethernet/intel/ice/Makefile
> @@ -49,3 +49,4 @@ ice-$(CONFIG_RFS_ACCEL) += ice_arfs.o
>  ice-$(CONFIG_XDP_SOCKETS) += ice_xsk.o
>  ice-$(CONFIG_ICE_SWITCHDEV) += ice_eswitch.o ice_eswitch_br.o
>  ice-$(CONFIG_GNSS) += ice_gnss.o
> +ice-$(CONFIG_ICE_VFIO_PCI) += ice_migration.o
> diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h
> index 9109006336f0..ec7f27d93924 100644
> --- a/drivers/net/ethernet/intel/ice/ice.h
> +++ b/drivers/net/ethernet/intel/ice/ice.h
> @@ -55,6 +55,7 @@
>  #include <net/vxlan.h>
>  #include <net/gtp.h>
>  #include <linux/ppp_defs.h>
> +#include <linux/net/intel/ice_migration.h>
>  #include "ice_devids.h"
>  #include "ice_type.h"
>  #include "ice_txrx.h"
> diff --git a/drivers/net/ethernet/intel/ice/ice_migration.c b/drivers/net/ethernet/intel/ice/ice_migration.c
> new file mode 100644
> index 000000000000..1aadb8577a41
> --- /dev/null
> +++ b/drivers/net/ethernet/intel/ice/ice_migration.c
> @@ -0,0 +1,68 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* Copyright (C) 2018-2023 Intel Corporation */
> +
> +#include "ice.h"
> +
> +/**
> + * ice_migration_get_vf - Get ice VF structure pointer by pdev
> + * @vf_pdev: pointer to ice vfio pci VF pdev structure
> + *
> + * Return nonzero for success, NULL for failure.
> + *
> + * ice_put_vf() should be called after finishing accessing VF
> + */
> +void *ice_migration_get_vf(struct pci_dev *vf_pdev)
> +{
> +	struct pci_dev *pf_pdev = vf_pdev->physfn;
> +	int vf_id = pci_iov_vf_id(vf_pdev);
> +	struct ice_pf *pf;
> +
> +	if (!pf_pdev || vf_id < 0)
> +		return NULL;
> +
> +	pf = pci_get_drvdata(pf_pdev);
> +	return ice_get_vf_by_id(pf, vf_id);
> +}
> +EXPORT_SYMBOL(ice_migration_get_vf);

This doesn't look right, you shouldn't need functions like this.

The VF knows itself, and it goes back to the PF safely from the VFIO
code. You should not be doing things like 'vf_pdev->physfn'

Loook at how the other drivers are structured.

Jason
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan