[Intel-wired-lan] [PATCH] ixgbe: report link state for VF devices

[Intel-wired-lan] [PATCH] ixgbe: report link state for VF devices

[ovidiu.panait]

From: Ovidiu Panait <ovidiu.panait@windriver.com>

The link state of VF devices can be controlled via "ip link set", but the
current state (auto/disabled) is not reported by "ip link show".

Update ixgbe_ndo_get_vf_config() to make this info available to userspace.

Fixes: 366fd1000995 ("ixgbe: add the ability for the PF to disable VF link state")
Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
index 9cfdfa8a4355..21b18d2f0d55 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
@@ -1849,5 +1849,6 @@ int ixgbe_ndo_get_vf_config(struct net_device *netdev,
 	ivi->spoofchk = adapter->vfinfo[vf].spoofchk_enabled;
 	ivi->rss_query_en = adapter->vfinfo[vf].rss_query_enabled;
 	ivi->trusted = adapter->vfinfo[vf].trusted;
+	ivi->linkstate = adapter->vfinfo[vf].link_state;
 	return 0;
 }
-- 
2.34.1

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Re: [Intel-wired-lan] [PATCH] ixgbe: report link state for VF devices

[Przemek Kitszel]

On 12/8/23 11:03, ovidiu.panait@windriver.com wrote:
> From: Ovidiu Panait <ovidiu.panait@windriver.com>
> 
> The link state of VF devices can be controlled via "ip link set", but the
> current state (auto/disabled) is not reported by "ip link show".
> 
> Update ixgbe_ndo_get_vf_config() to make this info available to userspace.
> 
> Fixes: 366fd1000995 ("ixgbe: add the ability for the PF to disable VF link state")

I would say that your commit extends ixgbe functionality, and is not a
bugfix. For such cases you should avoid Fixes: tag (just mentioning
commit "that introduced the code/ndo" is fine). With that, you could
also specify the tree as "iwl-next", what will also clarify that you
want Intel VAL to process this patch prior to application.

> Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
> ---
>   drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
> index 9cfdfa8a4355..21b18d2f0d55 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
> @@ -1849,5 +1849,6 @@ int ixgbe_ndo_get_vf_config(struct net_device *netdev,
>   	ivi->spoofchk = adapter->vfinfo[vf].spoofchk_enabled;
>   	ivi->rss_query_en = adapter->vfinfo[vf].rss_query_enabled;
>   	ivi->trusted = adapter->vfinfo[vf].trusted;
> +	ivi->linkstate = adapter->vfinfo[vf].link_state;
>   	return 0;
>   }

code looks fine,
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan