* Re: [Intel-wired-lan] [PATCH net-next] iavf: fix incorrect warning message in iavf_del_vlans()
2025-10-24 13:46 [Intel-wired-lan] [PATCH net-next] iavf: fix incorrect warning message in iavf_del_vlans() Alok Tiwari
@ 2025-10-24 17:13 ` Simon Horman
2025-10-27 7:18 ` Loktionov, Aleksandr
2025-10-27 8:45 ` Przemek Kitszel
2 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2025-10-24 17:13 UTC (permalink / raw)
To: Alok Tiwari
Cc: aleksander.lobakin, anthony.l.nguyen, przemyslaw.kitszel,
andrew+netdev, kuba, davem, edumazet, pabeni, intel-wired-lan,
netdev, alok.a.tiwarilinux
On Fri, Oct 24, 2025 at 06:46:26AM -0700, Alok Tiwari wrote:
> The warning message refers to "add VLAN changes" instead of
> "delete VLAN changes". Update the log string to use the correct text.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---
> drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> index 34a422a4a29c..6ad91db027d3 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> @@ -987,7 +987,7 @@ void iavf_del_vlans(struct iavf_adapter *adapter)
>
> len = virtchnl_struct_size(vvfl_v2, filters, count);
> if (len > IAVF_MAX_AQ_BUF_SIZE) {
> - dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n");
> + dev_warn(&adapter->pdev->dev, "Too many delete VLAN changes in one request\n");
> while (len > IAVF_MAX_AQ_BUF_SIZE)
> len = virtchnl_struct_size(vvfl_v2, filters,
> --count);
Thanks, this seems to be a copy-paste error as the text being
updated also appears in the preceding function in this file,
iavf_add_vlans().
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Intel-wired-lan] [PATCH net-next] iavf: fix incorrect warning message in iavf_del_vlans()
2025-10-24 13:46 [Intel-wired-lan] [PATCH net-next] iavf: fix incorrect warning message in iavf_del_vlans() Alok Tiwari
2025-10-24 17:13 ` Simon Horman
@ 2025-10-27 7:18 ` Loktionov, Aleksandr
2025-10-27 8:45 ` Przemek Kitszel
2 siblings, 0 replies; 5+ messages in thread
From: Loktionov, Aleksandr @ 2025-10-27 7:18 UTC (permalink / raw)
To: Alok Tiwari, Lobakin, Aleksander, Nguyen, Anthony L,
Kitszel, Przemyslaw, andrew+netdev@lunn.ch, kuba@kernel.org,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org
Cc: alok.a.tiwarilinux@gmail.com
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
> Of Alok Tiwari
> Sent: Friday, October 24, 2025 3:46 PM
> To: Lobakin, Aleksander <aleksander.lobakin@intel.com>; Nguyen,
> Anthony L <anthony.l.nguyen@intel.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@intel.com>; andrew+netdev@lunn.ch;
> kuba@kernel.org; davem@davemloft.net; edumazet@google.com;
> pabeni@redhat.com; horms@kernel.org; intel-wired-lan@lists.osuosl.org;
> netdev@vger.kernel.org
> Cc: alok.a.tiwarilinux@gmail.com; alok.a.tiwari@oracle.com
> Subject: [Intel-wired-lan] [PATCH net-next] iavf: fix incorrect
> warning message in iavf_del_vlans()
>
> The warning message refers to "add VLAN changes" instead of "delete
> VLAN changes". Update the log string to use the correct text.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---
> drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> index 34a422a4a29c..6ad91db027d3 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> @@ -987,7 +987,7 @@ void iavf_del_vlans(struct iavf_adapter *adapter)
>
> len = virtchnl_struct_size(vvfl_v2, filters, count);
> if (len > IAVF_MAX_AQ_BUF_SIZE) {
> - dev_warn(&adapter->pdev->dev, "Too many add VLAN
> changes in one request\n");
> + dev_warn(&adapter->pdev->dev, "Too many delete
> VLAN changes in one
> +request\n");
> while (len > IAVF_MAX_AQ_BUF_SIZE)
> len = virtchnl_struct_size(vvfl_v2,
> filters,
> --count);
> --
> 2.50.1
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Intel-wired-lan] [PATCH net-next] iavf: fix incorrect warning message in iavf_del_vlans()
2025-10-24 13:46 [Intel-wired-lan] [PATCH net-next] iavf: fix incorrect warning message in iavf_del_vlans() Alok Tiwari
2025-10-24 17:13 ` Simon Horman
2025-10-27 7:18 ` Loktionov, Aleksandr
@ 2025-10-27 8:45 ` Przemek Kitszel
2025-10-31 14:17 ` [Intel-wired-lan] [External] : " ALOK TIWARI
2 siblings, 1 reply; 5+ messages in thread
From: Przemek Kitszel @ 2025-10-27 8:45 UTC (permalink / raw)
To: Alok Tiwari, horms, Aleksandr Loktionov
Cc: alok.a.tiwarilinux, anthony.l.nguyen, andrew+netdev, kuba, davem,
edumazet, pabeni, intel-wired-lan, netdev, aleksander.lobakin
On 10/24/25 15:46, Alok Tiwari wrote:
> The warning message refers to "add VLAN changes" instead of
> "delete VLAN changes". Update the log string to use the correct text.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---
> drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> index 34a422a4a29c..6ad91db027d3 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> @@ -987,7 +987,7 @@ void iavf_del_vlans(struct iavf_adapter *adapter)
>
> len = virtchnl_struct_size(vvfl_v2, filters, count);
> if (len > IAVF_MAX_AQ_BUF_SIZE) {
> - dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n");
> + dev_warn(&adapter->pdev->dev, "Too many delete VLAN changes in one request\n");
> while (len > IAVF_MAX_AQ_BUF_SIZE)
> len = virtchnl_struct_size(vvfl_v2, filters,
> --count);
As Simon said this is a clear copy-paste error.
But the message itself is not great:
there is too many VLAN DEL requests to fit into 4k of memory, so what?
driver will just split into multiple virtchnl messages (with the "loop"
for splitting is put multiple call layers above from iavf_del_vlans()),
and everything is expected to work fine (despite the fact that this is
likely not tested frequently ;))
I would suggest to also lover the log message level to info, and
rephrase as "Too many VLAN delete changes requested, splitting into
multiple messages to PF",
or similar. And the same for ADD requests, the same for v1 message
(so 4 cases total).
with that there will be no eyebrow raised for the dmesg reader
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Intel-wired-lan] [External] : Re: [PATCH net-next] iavf: fix incorrect warning message in iavf_del_vlans()
2025-10-27 8:45 ` Przemek Kitszel
@ 2025-10-31 14:17 ` ALOK TIWARI
0 siblings, 0 replies; 5+ messages in thread
From: ALOK TIWARI @ 2025-10-31 14:17 UTC (permalink / raw)
To: Przemek Kitszel, horms, Aleksandr Loktionov
Cc: alok.a.tiwarilinux, anthony.l.nguyen, andrew+netdev, kuba, davem,
edumazet, pabeni, intel-wired-lan, netdev, aleksander.lobakin
On 10/27/2025 2:15 PM, Przemek Kitszel wrote:
>> diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/
>> drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
>> index 34a422a4a29c..6ad91db027d3 100644
>> --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
>> +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
>> @@ -987,7 +987,7 @@ void iavf_del_vlans(struct iavf_adapter *adapter)
>> len = virtchnl_struct_size(vvfl_v2, filters, count);
>> if (len > IAVF_MAX_AQ_BUF_SIZE) {
>> - dev_warn(&adapter->pdev->dev, "Too many add VLAN changes
>> in one request\n");
>> + dev_warn(&adapter->pdev->dev, "Too many delete VLAN
>> changes in one request\n");
>> while (len > IAVF_MAX_AQ_BUF_SIZE)
>> len = virtchnl_struct_size(vvfl_v2, filters,
>> --count);
>
> As Simon said this is a clear copy-paste error.
>
> But the message itself is not great:
> there is too many VLAN DEL requests to fit into 4k of memory, so what?
> driver will just split into multiple virtchnl messages (with the "loop"
> for splitting is put multiple call layers above from iavf_del_vlans()),
> and everything is expected to work fine (despite the fact that this is
> likely not tested frequently ;))
>
> I would suggest to also lover the log message level to info, and
> rephrase as "Too many VLAN delete changes requested, splitting into
> multiple messages to PF",
> or similar. And the same for ADD requests, the same for v1 message
> (so 4 cases total).
>
> with that there will be no eyebrow raised for the dmesg reader
I will send a new patch for this, covering both ADD and DELETE cases
using dev_info.
Thanks,
Alok
^ permalink raw reply [flat|nested] 5+ messages in thread