From: Kohei Enju <kohei@enjuk.jp>
To: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
dima.ruinskiy@intel.com, kohei.enju@gmail.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 0/2] igc: enable build_skb path
Date: Sun, 19 Apr 2026 13:54:57 +0900 [thread overview]
Message-ID: <aeRejyttAu4EO0HW@x1> (raw)
In-Reply-To: <20260317062205.39406-1-kohei@enjuk.jp>
On 03/17 06:21, Kohei Enju wrote:
> This series enables the build_skb RX path in igc, which is currently not
> enabled in any configuration.
>
> Patch 1/2 adds missing RX hardware timestamp handling in the build_skb
> path.
> Patch 2/2 enables the build_skb path when XDP is inactive and other
> conditions are met.
>
> Tested on Intel Corporation Ethernet Controller I226-V (rev 04).
>
> Changes:
> v2:
> - don't insist on reverse christmas tree, reducing net diff in the
> patch 1/2 (Dima)
> v1: https://lore.kernel.org/intel-wired-lan/20260307182808.155027-1-kohei@enjuk.jp/
>
> Kohei Enju (2):
> igc: set RX hardware timestamps in igc_build_skb()
> igc: enable build_skb on the non-XDP small-frame RX path
Hi Tony,
Could you drop this series from Intel's queue?
Sashiko pointed out a potential use-after-free when dereferencing RX
hardware timestamps with build_skb enabled, and I believe this concern
is valid.
https://sashiko.dev/#/patchset/20260317062205.39406-1-kohei%40enjuk.jp
I'm working on a new series to address this problem.
Thanks,
Kohei
prev parent reply other threads:[~2026-04-19 4:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 6:21 [Intel-wired-lan] [PATCH iwl-next v2 0/2] igc: enable build_skb path Kohei Enju
2026-03-17 6:21 ` [Intel-wired-lan] [PATCH iwl-next v2 1/2] igc: set RX hardware timestamps in igc_build_skb() Kohei Enju
2026-03-18 15:56 ` Ruinskiy, Dima
2026-03-23 17:21 ` Dahan, AvigailX
2026-03-17 6:21 ` [Intel-wired-lan] [PATCH iwl-next v2 2/2] igc: enable build_skb on the non-XDP small-frame RX path Kohei Enju
2026-03-18 15:57 ` Ruinskiy, Dima
2026-03-23 17:23 ` Dahan, AvigailX
2026-03-19 16:11 ` [Intel-wired-lan] [PATCH iwl-next v2 0/2] igc: enable build_skb path Simon Horman
2026-03-20 6:05 ` Kohei Enju
2026-03-20 20:30 ` Tony Nguyen
2026-03-21 7:13 ` Kohei Enju
2026-04-19 4:54 ` Kohei Enju [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeRejyttAu4EO0HW@x1 \
--to=kohei@enjuk.jp \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=dima.ruinskiy@intel.com \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kohei.enju@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox