From: Leon Romanovsky <leon@kernel.org>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH ipsec-next 8/8] xfrm: drop not needed flags variable in XFRM offload struct
Date: Thu, 5 May 2022 13:06:45 +0300 [thread overview]
Message-ID: <b0c39ee6e266ee021b810259fd73f5701fa929d1.1651743750.git.leonro@nvidia.com> (raw)
In-Reply-To: <cover.1651743750.git.leonro@nvidia.com>
From: Leon Romanovsky <leonro@nvidia.com>
After drivers were converted to rely on direction, the flags is not
used anymore and can be removed.
Reviewed-by: Raed Salem <raeds@nvidia.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
include/net/xfrm.h | 1 -
net/xfrm/xfrm_device.c | 3 ---
2 files changed, 4 deletions(-)
diff --git a/include/net/xfrm.h b/include/net/xfrm.h
index 45422f7be0c5..736c349de8bf 100644
--- a/include/net/xfrm.h
+++ b/include/net/xfrm.h
@@ -136,7 +136,6 @@ struct xfrm_dev_offload {
netdevice_tracker dev_tracker;
struct net_device *real_dev;
unsigned long offload_handle;
- u8 flags;
u8 dir : 2;
};
diff --git a/net/xfrm/xfrm_device.c b/net/xfrm/xfrm_device.c
index c818afca9137..35c7e89b2e7d 100644
--- a/net/xfrm/xfrm_device.c
+++ b/net/xfrm/xfrm_device.c
@@ -264,8 +264,6 @@ int xfrm_dev_state_add(struct net *net, struct xfrm_state *x,
xso->dev = dev;
netdev_tracker_alloc(dev, &xso->dev_tracker, GFP_ATOMIC);
xso->real_dev = dev;
- /* Don't forward bit that is not implemented */
- xso->flags = xuo->flags & ~XFRM_OFFLOAD_IPV6;
if (xuo->flags & XFRM_OFFLOAD_INBOUND)
xso->dir = XFRM_DEV_OFFLOAD_IN;
@@ -274,7 +272,6 @@ int xfrm_dev_state_add(struct net *net, struct xfrm_state *x,
err = dev->xfrmdev_ops->xdo_dev_state_add(x);
if (err) {
- xso->flags = 0;
xso->dev = NULL;
xso->dir = 0;
xso->real_dev = NULL;
--
2.35.1
next prev parent reply other threads:[~2022-05-05 10:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 10:06 [Intel-wired-lan] [PATCH ipsec-next 0/8] Be explicit with XFRM offload direction Leon Romanovsky
2022-05-05 10:06 ` [Intel-wired-lan] [PATCH ipsec-next 1/8] xfrm: free not used XFRM_ESP_NO_TRAILER flag Leon Romanovsky
2022-05-05 11:02 ` David Miller
2022-05-05 10:06 ` [Intel-wired-lan] [PATCH ipsec-next 2/8] xfrm: delete not used number of external headers Leon Romanovsky
2022-05-05 11:03 ` David Miller
2022-05-05 10:06 ` [Intel-wired-lan] [PATCH ipsec-next 3/8] xfrm: rename xfrm_state_offload struct to allow reuse Leon Romanovsky
2022-05-05 11:03 ` David Miller
2022-05-05 10:06 ` [Intel-wired-lan] [PATCH ipsec-next 4/8] xfrm: store and rely on direction to construct offload flags Leon Romanovsky
2022-05-05 10:06 ` [Intel-wired-lan] [PATCH ipsec-next 5/8] ixgbe: propagate XFRM offload state direction instead of flags Leon Romanovsky
2022-05-05 10:06 ` [Intel-wired-lan] [PATCH ipsec-next 6/8] netdevsim: rely on XFRM " Leon Romanovsky
2022-05-05 16:53 ` Jakub Kicinski
2022-05-05 10:06 ` [Intel-wired-lan] [PATCH ipsec-next 7/8] net/mlx5e: Use " Leon Romanovsky
2022-05-05 10:06 ` Leon Romanovsky [this message]
2022-05-07 7:28 ` [Intel-wired-lan] [PATCH ipsec-next 0/8] Be explicit with XFRM offload direction Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0c39ee6e266ee021b810259fd73f5701fa929d1.1651743750.git.leonro@nvidia.com \
--to=leon@kernel.org \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox