* Re: [Intel-wired-lan] [PATCH net-next] ice: Make use of assign_bit() API
2024-09-02 13:14 [Intel-wired-lan] [PATCH net-next] ice: Make use of assign_bit() API Hongbo Li
@ 2024-09-04 19:07 ` Gerhard Engleder
2024-09-17 19:10 ` Kuruvinakunnel, George
2024-09-17 22:22 ` Jacob Keller
2 siblings, 0 replies; 4+ messages in thread
From: Gerhard Engleder @ 2024-09-04 19:07 UTC (permalink / raw)
To: Hongbo Li, anthony.l.nguyen
Cc: przemyslaw.kitszel, edumazet, intel-wired-lan, netdev, kuba,
pabeni, davem
On 02.09.24 15:14, Hongbo Li wrote:
> We have for some time the assign_bit() API to replace open coded
>
> if (foo)
> set_bit(n, bar);
> else
> clear_bit(n, bar);
>
> Use this API to clean the code. No functional change intended.
>
> Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
> ---
> drivers/net/ethernet/intel/ice/ice_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index 46d3c5a34d6a..e3ad91b3ba77 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -6522,8 +6522,7 @@ ice_set_features(struct net_device *netdev, netdev_features_t features)
> if (changed & NETIF_F_HW_TC) {
> bool ena = !!(features & NETIF_F_HW_TC);
>
> - ena ? set_bit(ICE_FLAG_CLS_FLOWER, pf->flags) :
> - clear_bit(ICE_FLAG_CLS_FLOWER, pf->flags);
> + assign_bit(ICE_FLAG_CLS_FLOWER, pf->flags, ena);
> }
>
> if (changed & NETIF_F_LOOPBACK)
Reviewed-by: Gerhard Engleder <gerhard@engleder-embedded.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Intel-wired-lan] [PATCH net-next] ice: Make use of assign_bit() API
2024-09-02 13:14 [Intel-wired-lan] [PATCH net-next] ice: Make use of assign_bit() API Hongbo Li
2024-09-04 19:07 ` Gerhard Engleder
@ 2024-09-17 19:10 ` Kuruvinakunnel, George
2024-09-17 22:22 ` Jacob Keller
2 siblings, 0 replies; 4+ messages in thread
From: Kuruvinakunnel, George @ 2024-09-17 19:10 UTC (permalink / raw)
To: Hongbo Li, Nguyen, Anthony L
Cc: Kitszel, Przemyslaw, edumazet@google.com,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Hongbo
> Li
> Sent: Monday, September 2, 2024 6:14 AM
> To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
> Cc: Kitszel, Przemyslaw <przemyslaw.kitszel@intel.com>; edumazet@google.com;
> intel-wired-lan@lists.osuosl.org; lihongbo22@huawei.com; netdev@vger.kernel.org;
> kuba@kernel.org; pabeni@redhat.com; davem@davemloft.net
> Subject: [Intel-wired-lan] [PATCH net-next] ice: Make use of assign_bit() API
>
> We have for some time the assign_bit() API to replace open coded
>
> if (foo)
> set_bit(n, bar);
> else
> clear_bit(n, bar);
>
> Use this API to clean the code. No functional change intended.
>
> Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
> ---
> drivers/net/ethernet/intel/ice/ice_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Tested-by: George Kuruvinakunnel <george.kuruvinakunnel@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-wired-lan] [PATCH net-next] ice: Make use of assign_bit() API
2024-09-02 13:14 [Intel-wired-lan] [PATCH net-next] ice: Make use of assign_bit() API Hongbo Li
2024-09-04 19:07 ` Gerhard Engleder
2024-09-17 19:10 ` Kuruvinakunnel, George
@ 2024-09-17 22:22 ` Jacob Keller
2 siblings, 0 replies; 4+ messages in thread
From: Jacob Keller @ 2024-09-17 22:22 UTC (permalink / raw)
To: Hongbo Li, anthony.l.nguyen
Cc: przemyslaw.kitszel, edumazet, intel-wired-lan, netdev, kuba,
pabeni, davem
On 9/2/2024 6:14 AM, Hongbo Li wrote:
> We have for some time the assign_bit() API to replace open coded
>
> if (foo)
> set_bit(n, bar);
> else
> clear_bit(n, bar);
>
> Use this API to clean the code. No functional change intended.
>
> Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
> ---
> drivers/net/ethernet/intel/ice/ice_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index 46d3c5a34d6a..e3ad91b3ba77 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -6522,8 +6522,7 @@ ice_set_features(struct net_device *netdev, netdev_features_t features)
> if (changed & NETIF_F_HW_TC) {
> bool ena = !!(features & NETIF_F_HW_TC);
>
> - ena ? set_bit(ICE_FLAG_CLS_FLOWER, pf->flags) :
> - clear_bit(ICE_FLAG_CLS_FLOWER, pf->flags);
> + assign_bit(ICE_FLAG_CLS_FLOWER, pf->flags, ena);
> }
>
> if (changed & NETIF_F_LOOPBACK)
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread