Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nambiar, Amritha <amritha.nambiar@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next RFC 0/6] Configure cloud filters in i40e via tc/flower classifier
Date: Wed, 2 Aug 2017 11:17:08 -0700	[thread overview]
Message-ID: <db701a5c-8809-90d3-0e20-11fff34ab642@intel.com> (raw)
In-Reply-To: <146b5375-5d70-bb65-74aa-5c19c1de7daf@mojatatu.com>


On 8/2/2017 5:01 AM, Jamal Hadi Salim wrote:
> On 17-08-01 08:57 PM, Nambiar, Amritha wrote:
>>
>> On 8/1/2017 3:15 AM, Jamal Hadi Salim wrote:
>>> On 17-07-31 08:36 PM, Amritha Nambiar wrote:
> 
>>>>
>>>> # tc filter add dev eth0 protocol ip parent ffff: prio 1 flower\
>>>>     dst_ip 192.168.1.1/32 ip_proto udp dst_port 22\
>>>>     skip_sw indev eth0 action mirred ingress redirect dev eth0 tc 1
>>>>
>>>
>>> I think "queue 1" sounds better than "tc 1".
>>> "tc" is  already a keyword in a few places (even within that declaration
>>> above).
>>
>> The idea is to redirect to a traffic class that has queues assigned to
>> it and not a single queue i.e. these are actually queue groups and not a
>> single queue. So may be "qgroup 1" or "tcqgroup 1" fits better.
>>
> 
> Can you describe how this works? So the specific memeber of a
> a tcgroups show up on a specific rx DMA ring? If you only have
> 16 and 512 RX DMA rings - how does that work?
>

The Rx rule here is to redirect packets a specific traffic class. It is
the traffic class index (queue group index) that is offloaded to the
device. Queues were already configured for the traffic class by mapping
the queue counts and offsets and offloading this layout using the mqprio
framework. I had submitted a patch series for this which uses a new
hardware offload mode in mqprio to offload the TCs, the queue
configurations and the bandwidth rates for the TCs. So the 512 rings can
be mapped into 16 TCs using the mqprio offload mechanism, something like
this:
TC0 : 0 ? 15
TC1: 16 ? 31
TC2: 32 ? 33
TC3: 34 ? 49
.
.
.
TC15: 500 - 511

Now, once the TC configuration is prepared, it is just a matter of
hooking up the Rx rules to route traffic to the traffic class/queue
group. Rx queue selection within the queue group happens based on RSS.

> cheers,
> jamal
> 

  reply	other threads:[~2017-08-02 18:17 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-01  0:36 [Intel-wired-lan] [PATCH net-next RFC 0/6] Configure cloud filters in i40e via tc/flower classifier Amritha Nambiar
2017-08-01  0:37 ` [Intel-wired-lan] [PATCH 1/6] [net-next]net: sched: act_mirred: Extend redirect action to accept a traffic class Amritha Nambiar
2017-08-01 10:22   ` Jamal Hadi Salim
2017-08-02  1:12     ` Nambiar, Amritha
2017-08-01 10:44   ` Jamal Hadi Salim
2017-08-02  1:42     ` Nambiar, Amritha
2017-08-01 11:12   ` Jiri Pirko
2017-08-02  2:20     ` Nambiar, Amritha
2017-08-01  0:37 ` [Intel-wired-lan] [PATCH 2/6] [net-next]net: i40e: Maintain a mapping of TCs with the VSI seids Amritha Nambiar
2017-08-01  0:37 ` [Intel-wired-lan] [PATCH 3/6] [net-next]net: i40e: Extend set switch config command to accept cloud filter mode Amritha Nambiar
2017-08-01 10:48   ` Jamal Hadi Salim
2017-08-01  0:37 ` [Intel-wired-lan] [PATCH 4/6] [net-next]net: i40e: Admin queue definitions for cloud filters Amritha Nambiar
2017-08-01 19:16   ` Shannon Nelson
2017-08-14 18:59     ` Nambiar, Amritha
2017-08-01  0:38 ` [Intel-wired-lan] [PATCH 5/6] [net-next]net: i40e: Clean up of " Amritha Nambiar
2017-08-01 19:16   ` Shannon Nelson
2017-08-14 19:06     ` Nambiar, Amritha
2017-08-01  0:38 ` [Intel-wired-lan] [PATCH 6/6] [net-next]net: i40e: Enable cloud filters in i40e via tc/flower classifier Amritha Nambiar
2017-08-01 10:56   ` Jamal Hadi Salim
2017-08-02  2:13     ` Nambiar, Amritha
2017-08-02 12:02       ` Jamal Hadi Salim
2017-08-02 18:20         ` Nambiar, Amritha
2017-08-01 19:16   ` Shannon Nelson
2017-08-14 19:21     ` Nambiar, Amritha
2017-08-01 10:15 ` [Intel-wired-lan] [PATCH net-next RFC 0/6] Configure " Jamal Hadi Salim
2017-08-02  0:57   ` Nambiar, Amritha
2017-08-02 12:01     ` Jamal Hadi Salim
2017-08-02 18:17       ` Nambiar, Amritha [this message]
2017-08-01 19:16 ` Shannon Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db701a5c-8809-90d3-0e20-11fff34ab642@intel.com \
    --to=amritha.nambiar@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox