Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next v2] ice: Fix newline at the end of NL_SET_ERR_MSG_MOD
Date: Tue, 14 Sep 2021 16:40:24 -0700	[thread overview]
Message-ID: <dc1070b9-a2b0-2932-0150-5cb78ba104f5@intel.com> (raw)
In-Reply-To: <20210830141220.5547-1-wojciech.drewek@intel.com>

On 8/30/2021 7:12 AM, Wojciech Drewek wrote:
> Newline character is not needed at the end of NL_SET_ERR_MSG_MOD.
> 
> Signed-off-by: Wojciech Drewek <wojciech.drewek@intel.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
>  drivers/net/ethernet/intel/ice/ice_tc_lib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_tc_lib.c b/drivers/net/ethernet/intel/ice/ice_tc_lib.c
> index 34fe725b4a53..e01b16419923 100644
> --- a/drivers/net/ethernet/intel/ice/ice_tc_lib.c
> +++ b/drivers/net/ethernet/intel/ice/ice_tc_lib.c
> @@ -670,7 +670,7 @@ static int ice_del_tc_fltr(struct ice_vsi *vsi, struct ice_tc_flower_fltr *fltr)
>  	err = ice_rem_adv_rule_by_id(&pf->hw, &rule_rem);
>  	if (err) {
>  		if (err == ICE_ERR_DOES_NOT_EXIST) {
> -			NL_SET_ERR_MSG_MOD(fltr->extack, "filter does not exist\n");
> +			NL_SET_ERR_MSG_MOD(fltr->extack, "Filter does not exist");
>  			return -ENOENT;
>  		}
>  		NL_SET_ERR_MSG_MOD(fltr->extack, "Failed to delete TC flower filter");
> 
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>

      parent reply	other threads:[~2021-09-14 23:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30 14:12 [Intel-wired-lan] [PATCH net-next v2] ice: Fix newline at the end of NL_SET_ERR_MSG_MOD Wojciech Drewek
2021-09-14 16:24 ` G, GurucharanX
2021-09-14 23:40 ` Jesse Brandeburg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc1070b9-a2b0-2932-0150-5cb78ba104f5@intel.com \
    --to=jesse.brandeburg@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox