* [Intel-wired-lan] [PATCH net-next v2] ice: Fix newline at the end of NL_SET_ERR_MSG_MOD
@ 2021-08-30 14:12 Wojciech Drewek
2021-09-14 16:24 ` G, GurucharanX
2021-09-14 23:40 ` Jesse Brandeburg
0 siblings, 2 replies; 3+ messages in thread
From: Wojciech Drewek @ 2021-08-30 14:12 UTC (permalink / raw)
To: intel-wired-lan
Newline character is not needed at the end of NL_SET_ERR_MSG_MOD.
Signed-off-by: Wojciech Drewek <wojciech.drewek@intel.com>
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
---
drivers/net/ethernet/intel/ice/ice_tc_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_tc_lib.c b/drivers/net/ethernet/intel/ice/ice_tc_lib.c
index 34fe725b4a53..e01b16419923 100644
--- a/drivers/net/ethernet/intel/ice/ice_tc_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_tc_lib.c
@@ -670,7 +670,7 @@ static int ice_del_tc_fltr(struct ice_vsi *vsi, struct ice_tc_flower_fltr *fltr)
err = ice_rem_adv_rule_by_id(&pf->hw, &rule_rem);
if (err) {
if (err == ICE_ERR_DOES_NOT_EXIST) {
- NL_SET_ERR_MSG_MOD(fltr->extack, "filter does not exist\n");
+ NL_SET_ERR_MSG_MOD(fltr->extack, "Filter does not exist");
return -ENOENT;
}
NL_SET_ERR_MSG_MOD(fltr->extack, "Failed to delete TC flower filter");
--
2.30.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Intel-wired-lan] [PATCH net-next v2] ice: Fix newline at the end of NL_SET_ERR_MSG_MOD
2021-08-30 14:12 [Intel-wired-lan] [PATCH net-next v2] ice: Fix newline at the end of NL_SET_ERR_MSG_MOD Wojciech Drewek
@ 2021-09-14 16:24 ` G, GurucharanX
2021-09-14 23:40 ` Jesse Brandeburg
1 sibling, 0 replies; 3+ messages in thread
From: G, GurucharanX @ 2021-09-14 16:24 UTC (permalink / raw)
To: intel-wired-lan
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Wojciech Drewek
> Sent: Monday, August 30, 2021 7:42 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH net-next v2] ice: Fix newline at the end of
> NL_SET_ERR_MSG_MOD
>
> Newline character is not needed at the end of NL_SET_ERR_MSG_MOD.
>
> Signed-off-by: Wojciech Drewek <wojciech.drewek@intel.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> drivers/net/ethernet/intel/ice/ice_tc_lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Intel-wired-lan] [PATCH net-next v2] ice: Fix newline at the end of NL_SET_ERR_MSG_MOD
2021-08-30 14:12 [Intel-wired-lan] [PATCH net-next v2] ice: Fix newline at the end of NL_SET_ERR_MSG_MOD Wojciech Drewek
2021-09-14 16:24 ` G, GurucharanX
@ 2021-09-14 23:40 ` Jesse Brandeburg
1 sibling, 0 replies; 3+ messages in thread
From: Jesse Brandeburg @ 2021-09-14 23:40 UTC (permalink / raw)
To: intel-wired-lan
On 8/30/2021 7:12 AM, Wojciech Drewek wrote:
> Newline character is not needed at the end of NL_SET_ERR_MSG_MOD.
>
> Signed-off-by: Wojciech Drewek <wojciech.drewek@intel.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> drivers/net/ethernet/intel/ice/ice_tc_lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_tc_lib.c b/drivers/net/ethernet/intel/ice/ice_tc_lib.c
> index 34fe725b4a53..e01b16419923 100644
> --- a/drivers/net/ethernet/intel/ice/ice_tc_lib.c
> +++ b/drivers/net/ethernet/intel/ice/ice_tc_lib.c
> @@ -670,7 +670,7 @@ static int ice_del_tc_fltr(struct ice_vsi *vsi, struct ice_tc_flower_fltr *fltr)
> err = ice_rem_adv_rule_by_id(&pf->hw, &rule_rem);
> if (err) {
> if (err == ICE_ERR_DOES_NOT_EXIST) {
> - NL_SET_ERR_MSG_MOD(fltr->extack, "filter does not exist\n");
> + NL_SET_ERR_MSG_MOD(fltr->extack, "Filter does not exist");
> return -ENOENT;
> }
> NL_SET_ERR_MSG_MOD(fltr->extack, "Failed to delete TC flower filter");
>
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-14 23:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-30 14:12 [Intel-wired-lan] [PATCH net-next v2] ice: Fix newline at the end of NL_SET_ERR_MSG_MOD Wojciech Drewek
2021-09-14 16:24 ` G, GurucharanX
2021-09-14 23:40 ` Jesse Brandeburg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox