From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Andrii Staikov <andrii.staikov@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v1] i40e: fix potential memory leaks in i40e_remove()
Date: Fri, 4 Aug 2023 14:32:12 -0700 [thread overview]
Message-ID: <e25072ed-5c55-41c8-3a29-cc1cc8e64693@intel.com> (raw)
In-Reply-To: <20230802074854.3650629-1-andrii.staikov@intel.com>
On 8/2/2023 12:48 AM, Andrii Staikov wrote:
> Add defencive loop for all vsi-s and force resources cleanup.
Please provide more details; this doesn't provide much information.
Please look into:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
Also, s/defencive/defensive
> Fixes: 41c445ff0f48 ("i40e: main driver core")
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> Signed-off-by: Andrii Staikov <andrii.staikov@intel.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_main.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
> index 29ad1797adce..1c892b14a337 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> @@ -16326,8 +16326,14 @@ static void i40e_remove(struct pci_dev *pdev)
> /* Now we can shutdown the PF's VSI, just before we kill
> * adminq and hmc.
> */
> - if (pf->vsi[pf->lan_vsi])
> - i40e_vsi_release(pf->vsi[pf->lan_vsi]);
> + for (i = pf->num_alloc_vsi; i--;)
> + if (pf->vsi[i]) {
> + i40e_vsi_close(pf->vsi[i]);
> + i40e_vsi_free_q_vectors(pf->vsi[i]);
> + i40e_vsi_release(pf->vsi[i]);
> + kfree(pf->vsi[i]);
> + pf->vsi[i] = NULL;
> + }
>
> i40e_cloud_filter_exit(pf);
>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
prev parent reply other threads:[~2023-08-04 21:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 7:48 [Intel-wired-lan] [PATCH iwl-net v1] i40e: fix potential memory leaks in i40e_remove() Andrii Staikov
2023-08-04 21:32 ` Tony Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e25072ed-5c55-41c8-3a29-cc1cc8e64693@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=andrii.staikov@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox