[Intel-wired-lan] [PATCH iwl-net v1] i40e: fix potential memory leaks in i40e_remove()

[Intel-wired-lan] [PATCH iwl-net v1] i40e: fix potential memory leaks in i40e_remove()

[Andrii Staikov]

Add defencive loop for all vsi-s and force resources cleanup.

Fixes: 41c445ff0f48 ("i40e: main driver core")
Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Signed-off-by: Andrii Staikov <andrii.staikov@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 29ad1797adce..1c892b14a337 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -16326,8 +16326,14 @@ static void i40e_remove(struct pci_dev *pdev)
 	/* Now we can shutdown the PF's VSI, just before we kill
 	 * adminq and hmc.
 	 */
-	if (pf->vsi[pf->lan_vsi])
-		i40e_vsi_release(pf->vsi[pf->lan_vsi]);
+	for (i = pf->num_alloc_vsi; i--;)
+		if (pf->vsi[i]) {
+			i40e_vsi_close(pf->vsi[i]);
+			i40e_vsi_free_q_vectors(pf->vsi[i]);
+			i40e_vsi_release(pf->vsi[i]);
+			kfree(pf->vsi[i]);
+			pf->vsi[i] = NULL;
+		}
 
 	i40e_cloud_filter_exit(pf);
 
-- 
2.25.1

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Re: [Intel-wired-lan] [PATCH iwl-net v1] i40e: fix potential memory leaks in i40e_remove()

[Tony Nguyen]

On 8/2/2023 12:48 AM, Andrii Staikov wrote:
> Add defencive loop for all vsi-s and force resources cleanup.

Please provide more details; this doesn't provide much information.

Please look into:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes

Also, s/defencive/defensive

> Fixes: 41c445ff0f48 ("i40e: main driver core")
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> Signed-off-by: Andrii Staikov <andrii.staikov@intel.com>
> ---
>   drivers/net/ethernet/intel/i40e/i40e_main.c | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
> index 29ad1797adce..1c892b14a337 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> @@ -16326,8 +16326,14 @@ static void i40e_remove(struct pci_dev *pdev)
>   	/* Now we can shutdown the PF's VSI, just before we kill
>   	 * adminq and hmc.
>   	 */
> -	if (pf->vsi[pf->lan_vsi])
> -		i40e_vsi_release(pf->vsi[pf->lan_vsi]);
> +	for (i = pf->num_alloc_vsi; i--;)
> +		if (pf->vsi[i]) {
> +			i40e_vsi_close(pf->vsi[i]);
> +			i40e_vsi_free_q_vectors(pf->vsi[i]);
> +			i40e_vsi_release(pf->vsi[i]);
> +			kfree(pf->vsi[i]);
> +			pf->vsi[i] = NULL;
> +		}
>   
>   	i40e_cloud_filter_exit(pf);
>   
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan