From: Jacob Keller <jacob.e.keller@intel.com>
To: Karol Kolacinski <karol.kolacinski@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: <netdev@vger.kernel.org>,
Arkadiusz Kubalewski <Arkadiusz.kubalewski@intel.com>,
<anthony.l.nguyen@intel.com>, <przemyslaw.kitszel@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH v2 iwl-net 4/4] ice: Add correct PHY lane assignment
Date: Wed, 16 Oct 2024 16:29:18 -0700 [thread overview]
Message-ID: <e2ed6973-cccb-46be-b847-3f18c85b3bf0@intel.com> (raw)
In-Reply-To: <20241010142254.2047150-5-karol.kolacinski@intel.com>
On 10/10/2024 7:21 AM, Karol Kolacinski wrote:
> /**
> * ice_ptp_init_phy_e825 - initialize PHY parameters
> * @hw: pointer to the HW struct
> @@ -2743,8 +2723,6 @@ static void ice_ptp_init_phy_e825(struct ice_hw *hw)
> err = ice_read_phy_eth56g(hw, hw->pf_id, PHY_REG_REVISION, &phy_rev);
> if (err || phy_rev != PHY_REVISION_ETH56G)
> ptp->phy_model = ICE_PHY_UNSUP;
> -
> - ptp->is_2x50g_muxed_topo = ice_is_muxed_topo(hw);
> }
>
Once we remove ptp->phy_model, this check for the PHY revision seems
like it is meaningless?
Thanks,
Jake
next prev parent reply other threads:[~2024-10-16 23:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 14:21 [Intel-wired-lan] [PATCH v2 iwl-net 0/4] Fix E825 initialization Karol Kolacinski
2024-10-10 14:21 ` [Intel-wired-lan] [PATCH v2 iwl-net 1/4] ice: " Karol Kolacinski
2024-10-16 23:24 ` Jacob Keller
2024-10-26 17:16 ` Nitka, Grzegorz
2024-10-10 14:21 ` [Intel-wired-lan] [PATCH v2 iwl-net 2/4] ice: Fix quad registers read on E825 Karol Kolacinski
2024-10-28 9:15 ` Nitka, Grzegorz
2024-10-10 14:21 ` [Intel-wired-lan] [PATCH v2 iwl-net 3/4] ice: Fix ETH56G FC-FEC Rx offset value Karol Kolacinski
2024-10-10 14:21 ` [Intel-wired-lan] [PATCH v2 iwl-net 4/4] ice: Add correct PHY lane assignment Karol Kolacinski
2024-10-16 23:29 ` Jacob Keller [this message]
2024-10-26 17:29 ` Nitka, Grzegorz
2024-10-16 23:27 ` [Intel-wired-lan] [PATCH v2 iwl-net 0/4] Fix E825 initialization Jacob Keller
2024-10-28 19:42 ` Nitka, Grzegorz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2ed6973-cccb-46be-b847-3f18c85b3bf0@intel.com \
--to=jacob.e.keller@intel.com \
--cc=Arkadiusz.kubalewski@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=karol.kolacinski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox