From: "naamax.meir" <naamax.meir@linux.intel.com>
To: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>,
intel-wired-lan@osuosl.org
Cc: tee.min.tan@linux.intel.com
Subject: Re: [Intel-wired-lan] [PATCH 5/5] igc: Set Qbv start_time and end_time to end_time if not being configured in GCL
Date: Sun, 13 Nov 2022 09:33:30 +0200 [thread overview]
Message-ID: <e3fda18d-ce88-1407-9d60-4f559c1ed018@linux.intel.com> (raw)
In-Reply-To: <20221030045324.25207-6-muhammad.husaini.zulkifli@intel.com>
On 10/30/2022 06:53, Muhammad Husaini Zulkifli wrote:
> From: Tan Tee Min <tee.min.tan@linux.intel.com>
>
> The default setting of end_time minus start_time is whole 1 second.
> Thus, if it's not being configured in any GCL entry then it will be
> staying at original 1 second.
>
> This patch is changing the start_time and end_time to be end_time as
> if setting zero will be having weird HW behavior where the gate will
> not be fully closed.
>
> Signed-off-by: Tan Tee Min <tee.min.tan@linux.intel.com>
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc_main.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
prev parent reply other threads:[~2022-11-13 7:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-30 4:53 [Intel-wired-lan] [PATCH 0/5] igc: TSN Qbv Improvement for I226 Stepping Muhammad Husaini Zulkifli
2022-10-30 4:53 ` [Intel-wired-lan] [PATCH 1/5] igc: allow BaseTime 0 enrollment for Qbv Muhammad Husaini Zulkifli
2022-11-13 7:28 ` naamax.meir
2022-10-30 4:53 ` [Intel-wired-lan] [PATCH 2/5] igc: remove I226 Qbv BaseTime restriction Muhammad Husaini Zulkifli
2022-11-03 18:26 ` Tony Nguyen
2022-11-04 8:28 ` Zulkifli, Muhammad Husaini
2022-11-13 7:29 ` naamax.meir
2022-10-30 4:53 ` [Intel-wired-lan] [PATCH 3/5] igc: recalculate Qbv end_time by considering cycle time Muhammad Husaini Zulkifli
2022-11-13 7:31 ` naamax.meir
2022-10-30 4:53 ` [Intel-wired-lan] [PATCH 4/5] igc: enable Qbv configuration for 2nd GCL Muhammad Husaini Zulkifli
2022-11-13 7:32 ` naamax.meir
2022-10-30 4:53 ` [Intel-wired-lan] [PATCH 5/5] igc: Set Qbv start_time and end_time to end_time if not being configured in GCL Muhammad Husaini Zulkifli
2022-11-13 7:33 ` naamax.meir [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3fda18d-ce88-1407-9d60-4f559c1ed018@linux.intel.com \
--to=naamax.meir@linux.intel.com \
--cc=intel-wired-lan@osuosl.org \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=tee.min.tan@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox