[Intel-wired-lan] [PATCH net-next] iavf: clarify VLAN add/delete log messages and lower log level

[Intel-wired-lan] [PATCH net-next] iavf: clarify VLAN add/delete log messages and lower log level

[Alok Tiwari]

The current dev_warn messages for too many VLAN changes are confusing
and one place incorrectly reference "add" instead of "delete" VLANs
due to copy-paste errors.

- Use dev_info instead of dev_warn to lower the log level.
- Rephrase the message to: "Too many VLAN [add|delete] changes requested,
  splitting into multiple messages to PF".

Suggested-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
https://lore.kernel.org/all/47f8c95c-bac4-471f-8e58-9155c6e58cb5@intel.com/
---
 drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
index 34a422a4a29c..3593c0b45cf7 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
@@ -793,7 +793,8 @@ void iavf_add_vlans(struct iavf_adapter *adapter)
 
 		len = virtchnl_struct_size(vvfl, vlan_id, count);
 		if (len > IAVF_MAX_AQ_BUF_SIZE) {
-			dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n");
+			dev_info(&adapter->pdev->dev, "Too many VLAN add changes requested,\n"
+				"splitting into multiple messages to PF\n");
 			while (len > IAVF_MAX_AQ_BUF_SIZE)
 				len = virtchnl_struct_size(vvfl, vlan_id,
 							   --count);
@@ -838,7 +839,8 @@ void iavf_add_vlans(struct iavf_adapter *adapter)
 
 		len = virtchnl_struct_size(vvfl_v2, filters, count);
 		if (len > IAVF_MAX_AQ_BUF_SIZE) {
-			dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n");
+			dev_info(&adapter->pdev->dev, "Too many VLAN add changes requested,\n"
+				"splitting into multiple messages to PF\n");
 			while (len > IAVF_MAX_AQ_BUF_SIZE)
 				len = virtchnl_struct_size(vvfl_v2, filters,
 							   --count);
@@ -941,7 +943,8 @@ void iavf_del_vlans(struct iavf_adapter *adapter)
 
 		len = virtchnl_struct_size(vvfl, vlan_id, count);
 		if (len > IAVF_MAX_AQ_BUF_SIZE) {
-			dev_warn(&adapter->pdev->dev, "Too many delete VLAN changes in one request\n");
+			dev_info(&adapter->pdev->dev, "Too many VLAN delete changes requested,\n"
+				"splitting into multiple messages to PF\n");
 			while (len > IAVF_MAX_AQ_BUF_SIZE)
 				len = virtchnl_struct_size(vvfl, vlan_id,
 							   --count);
@@ -987,7 +990,8 @@ void iavf_del_vlans(struct iavf_adapter *adapter)
 
 		len = virtchnl_struct_size(vvfl_v2, filters, count);
 		if (len > IAVF_MAX_AQ_BUF_SIZE) {
-			dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n");
+			dev_info(&adapter->pdev->dev, "Too many VLAN delete changes requested,\n"
+				"splitting into multiple messages to PF\n");
 			while (len > IAVF_MAX_AQ_BUF_SIZE)
 				len = virtchnl_struct_size(vvfl_v2, filters,
 							   --count);
-- 
2.50.1

Re: [Intel-wired-lan] [PATCH net-next] iavf: clarify VLAN add/delete log messages and lower log level

[Przemek Kitszel]

On 11/3/25 10:03, Alok Tiwari wrote:
> The current dev_warn messages for too many VLAN changes are confusing
> and one place incorrectly reference "add" instead of "delete" VLANs
> due to copy-paste errors.
> 
> - Use dev_info instead of dev_warn to lower the log level.
> - Rephrase the message to: "Too many VLAN [add|delete] changes requested,
>    splitting into multiple messages to PF".
> 
> Suggested-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>

thank you!
just two minor nits, but the messages are good already, so:
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>

> ---
> https://lore.kernel.org/all/47f8c95c-bac4-471f-8e58-9155c6e58cb5@intel.com/
> ---
>   drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 12 ++++++++----
>   1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> index 34a422a4a29c..3593c0b45cf7 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> @@ -793,7 +793,8 @@ void iavf_add_vlans(struct iavf_adapter *adapter)
>   
>   		len = virtchnl_struct_size(vvfl, vlan_id, count);
>   		if (len > IAVF_MAX_AQ_BUF_SIZE) {
> -			dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n");
> +			dev_info(&adapter->pdev->dev, "Too many VLAN add changes requested,\n"
> +				"splitting into multiple messages to PF\n");

perhaps it is too much bikeshedding for such a change, sorry, but
I would rather remove the newline in the middle

nit: another thing that I would consider is to differentiate the 
messages (v1/v2 or A/B, or whatever) for different protocol versions

>   			while (len > IAVF_MAX_AQ_BUF_SIZE)
>   				len = virtchnl_struct_size(vvfl, vlan_id,
>   							   --count);
> @@ -838,7 +839,8 @@ void iavf_add_vlans(struct iavf_adapter *adapter)
>   
>   		len = virtchnl_struct_size(vvfl_v2, filters, count);
>   		if (len > IAVF_MAX_AQ_BUF_SIZE) {
> -			dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n");
> +			dev_info(&adapter->pdev->dev, "Too many VLAN add changes requested,\n"
> +				"splitting into multiple messages to PF\n");
>   			while (len > IAVF_MAX_AQ_BUF_SIZE)
>   				len = virtchnl_struct_size(vvfl_v2, filters,
>   							   --count);
> @@ -941,7 +943,8 @@ void iavf_del_vlans(struct iavf_adapter *adapter)
>   
>   		len = virtchnl_struct_size(vvfl, vlan_id, count);
>   		if (len > IAVF_MAX_AQ_BUF_SIZE) {
> -			dev_warn(&adapter->pdev->dev, "Too many delete VLAN changes in one request\n");
> +			dev_info(&adapter->pdev->dev, "Too many VLAN delete changes requested,\n"
> +				"splitting into multiple messages to PF\n");
>   			while (len > IAVF_MAX_AQ_BUF_SIZE)
>   				len = virtchnl_struct_size(vvfl, vlan_id,
>   							   --count);
> @@ -987,7 +990,8 @@ void iavf_del_vlans(struct iavf_adapter *adapter)
>   
>   		len = virtchnl_struct_size(vvfl_v2, filters, count);
>   		if (len > IAVF_MAX_AQ_BUF_SIZE) {
> -			dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n");
> +			dev_info(&adapter->pdev->dev, "Too many VLAN delete changes requested,\n"
> +				"splitting into multiple messages to PF\n");
>   			while (len > IAVF_MAX_AQ_BUF_SIZE)
>   				len = virtchnl_struct_size(vvfl_v2, filters,
>   							   --count);

Re: [Intel-wired-lan] [External] : Re: [PATCH net-next] iavf: clarify VLAN add/delete log messages and lower log level

[ALOK TIWARI]

On 11/3/2025 2:57 PM, Przemek Kitszel wrote:
> On 11/3/25 10:03, Alok Tiwari wrote:
>> The current dev_warn messages for too many VLAN changes are confusing
>> and one place incorrectly reference "add" instead of "delete" VLANs
>> due to copy-paste errors.
>>
>> - Use dev_info instead of dev_warn to lower the log level.
>> - Rephrase the message to: "Too many VLAN [add|delete] changes requested,
>>    splitting into multiple messages to PF".
>>
>> Suggested-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> 
> thank you!
> just two minor nits, but the messages are good already, so:
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> 
>> ---
>> https://urldefense.com/v3/__https://lore.kernel.org/all/47f8c95c- 
>> bac4-471f-8e58-9155c6e58cb5@intel.com/__;!!ACWV5N9M2RV99hQ! 
>> MulRvlOtC3JAON-O816_nR2P2geYBHDIx86XOr_i1afc9gjSrXfpcVwFmP6uM0p1- 
>> kFN64zBSLjwS3XvTDQ6nJ5R2hyIaQ$ ---
>>   drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 12 ++++++++----
>>   1 file changed, 8 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/ 
>> drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
>> index 34a422a4a29c..3593c0b45cf7 100644
>> --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
>> +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
>> @@ -793,7 +793,8 @@ void iavf_add_vlans(struct iavf_adapter *adapter)
>>           len = virtchnl_struct_size(vvfl, vlan_id, count);
>>           if (len > IAVF_MAX_AQ_BUF_SIZE) {
>> -            dev_warn(&adapter->pdev->dev, "Too many add VLAN changes 
>> in one request\n");
>> +            dev_info(&adapter->pdev->dev, "Too many VLAN add changes 
>> requested,\n"
>> +                "splitting into multiple messages to PF\n");
> 
> perhaps it is too much bikeshedding for such a change, sorry, but
> I would rather remove the newline in the middle
> 
> nit: another thing that I would consider is to differentiate the 
> messages (v1/v2 or A/B, or whatever) for different protocol versions


Thanks Przemek for the feedback.

I initially had the message on a single line, but checkpatch.pl 
reported: "WARNING: quoted string split across lines"

To avoid that warning, I added the "\n" and split the message.
I can drop the newline and suppress the warning if the maintainer
community prefers.
I just wanted to stay consistent with checkpatch recommendations.

good point, I can adjust the wording and add version tags (v1/v2)
now The messages currently look like this:

dev_info(&adapter->pdev->dev, "vvfl Too many VLAN add changes requested, "
          "splitting into multiple messages to PF\n");

dev_info(&adapter->pdev->dev, "vvfl_v2 Too many VLAN add changes 
requested, "
          "splitting into multiple messages to PF\n");

Thanks,
Alok

Re: [Intel-wired-lan] [PATCH net-next] iavf: clarify VLAN add/delete log messages and lower log level

[Loktionov, Aleksandr]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
> Of Alok Tiwari
> Sent: Monday, November 3, 2025 10:03 AM
> To: Kitszel, Przemyslaw <przemyslaw.kitszel@intel.com>; Lobakin,
> Aleksander <aleksander.lobakin@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; andrew+netdev@lunn.ch; kuba@kernel.org;
> davem@davemloft.net; edumazet@google.com; pabeni@redhat.com;
> horms@kernel.org; intel-wired-lan@lists.osuosl.org;
> netdev@vger.kernel.org
> Cc: alok.a.tiwarilinux@gmail.com; alok.a.tiwari@oracle.com
> Subject: [Intel-wired-lan] [PATCH net-next] iavf: clarify VLAN
> add/delete log messages and lower log level
> 
> The current dev_warn messages for too many VLAN changes are confusing
> and one place incorrectly reference "add" instead of "delete" VLANs
> due to copy-paste errors.
> 
> - Use dev_info instead of dev_warn to lower the log level.
> - Rephrase the message to: "Too many VLAN [add|delete] changes
> requested,
>   splitting into multiple messages to PF".
> 
> Suggested-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---
> https://lore.kernel.org/all/47f8c95c-bac4-471f-8e58-
> 9155c6e58cb5@intel.com/
> ---
>  drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> index 34a422a4a29c..3593c0b45cf7 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> @@ -793,7 +793,8 @@ void iavf_add_vlans(struct iavf_adapter *adapter)
> 
>  		len = virtchnl_struct_size(vvfl, vlan_id, count);
>  		if (len > IAVF_MAX_AQ_BUF_SIZE) {
> -			dev_warn(&adapter->pdev->dev, "Too many add VLAN
> changes in one request\n");
> +			dev_info(&adapter->pdev->dev, "Too many VLAN add
> changes requested,\n"
> +				"splitting into multiple messages to
> PF\n");
>  			while (len > IAVF_MAX_AQ_BUF_SIZE)
>  				len = virtchnl_struct_size(vvfl, vlan_id,
>  							   --count);
> @@ -838,7 +839,8 @@ void iavf_add_vlans(struct iavf_adapter *adapter)
> 
>  		len = virtchnl_struct_size(vvfl_v2, filters, count);
>  		if (len > IAVF_MAX_AQ_BUF_SIZE) {
> -			dev_warn(&adapter->pdev->dev, "Too many add VLAN
> changes in one request\n");
> +			dev_info(&adapter->pdev->dev, "Too many VLAN add
> changes requested,\n"
> +				"splitting into multiple messages to
> PF\n");
Kernel style prefers single-line messages unless absolutely necessary. Multi-line dev_info() is unusual for simple info.

dev_info() is acceptable for non-critical conditions, but consider netdev_info() for network-related messages (common in drivers).

...

Re: [Intel-wired-lan] [External] : Re: [PATCH net-next] iavf: clarify VLAN add/delete log messages and lower log level

[Loktionov, Aleksandr]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
> Of ALOK TIWARI
> Sent: Monday, November 3, 2025 11:17 AM
> To: Kitszel, Przemyslaw <przemyslaw.kitszel@intel.com>
> Cc: alok.a.tiwarilinux@gmail.com; Lobakin, Aleksander
> <aleksander.lobakin@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; andrew+netdev@lunn.ch; kuba@kernel.org;
> davem@davemloft.net; edumazet@google.com; pabeni@redhat.com;
> horms@kernel.org; intel-wired-lan@lists.osuosl.org;
> netdev@vger.kernel.org
> Subject: Re: [Intel-wired-lan] [External] : Re: [PATCH net-next] iavf:
> clarify VLAN add/delete log messages and lower log level
> 
> 
> 
> On 11/3/2025 2:57 PM, Przemek Kitszel wrote:
> > On 11/3/25 10:03, Alok Tiwari wrote:
> >> The current dev_warn messages for too many VLAN changes are
> confusing
> >> and one place incorrectly reference "add" instead of "delete" VLANs
> >> due to copy-paste errors.
> >>
> >> - Use dev_info instead of dev_warn to lower the log level.
> >> - Rephrase the message to: "Too many VLAN [add|delete] changes
> >> requested,
> >>    splitting into multiple messages to PF".
> >>
> >> Suggested-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> >> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> >
> > thank you!
> > just two minor nits, but the messages are good already, so:
> > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> >
> >> ---
> >> https://urldefense.com/v3/__https://lore.kernel.org/all/47f8c95c-
> >> bac4-471f-8e58-9155c6e58cb5@intel.com/__;!!ACWV5N9M2RV99hQ!
> >> MulRvlOtC3JAON-O816_nR2P2geYBHDIx86XOr_i1afc9gjSrXfpcVwFmP6uM0p1-
> >> kFN64zBSLjwS3XvTDQ6nJ5R2hyIaQ$ ---
> >>   drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 12 ++++++++----
> >>   1 file changed, 8 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/
> >> drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> >> index 34a422a4a29c..3593c0b45cf7 100644
> >> --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> >> +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> >> @@ -793,7 +793,8 @@ void iavf_add_vlans(struct iavf_adapter
> *adapter)
> >>           len = virtchnl_struct_size(vvfl, vlan_id, count);
> >>           if (len > IAVF_MAX_AQ_BUF_SIZE) {
> >> -            dev_warn(&adapter->pdev->dev, "Too many add VLAN
> changes
> >> in one request\n");
> >> +            dev_info(&adapter->pdev->dev, "Too many VLAN add
> changes
> >> requested,\n"
> >> +                "splitting into multiple messages to PF\n");
> >
> > perhaps it is too much bikeshedding for such a change, sorry, but I
> > would rather remove the newline in the middle
> >
> > nit: another thing that I would consider is to differentiate the
> > messages (v1/v2 or A/B, or whatever) for different protocol versions
> 
> 
> Thanks Przemek for the feedback.
> 
> I initially had the message on a single line, but checkpatch.pl
> reported: "WARNING: quoted string split across lines"
> 
> To avoid that warning, I added the "\n" and split the message.
> I can drop the newline and suppress the warning if the maintainer
> community prefers.
> I just wanted to stay consistent with checkpatch recommendations.
> 
> good point, I can adjust the wording and add version tags (v1/v2) now
> The messages currently look like this:
> 
> dev_info(&adapter->pdev->dev, "vvfl Too many VLAN add changes
> requested, "
>           "splitting into multiple messages to PF\n");
> 
> dev_info(&adapter->pdev->dev, "vvfl_v2 Too many VLAN add changes
> requested, "
>           "splitting into multiple messages to PF\n");
> 
> Thanks,
> Alok

Thanks for clarifying, Alok.
checkpatch.pl warnings about split strings are advisory, not mandatory. For log messages, kernel style generally prefers a single, readable line rather than introducing "\n" just to silence that warning. Multi-line messages make grepping harder and are rarely needed for short text.
So please keep the message on one line, even if that means ignoring the checkpatch warning.

Something like:
dev_info(&adapter->pdev->dev,
         "vvfl Too many VLAN add requests; splitting into multiple messages to PF\n");

Same for the delete case. Dropping the comma for a semicolon improves clarity.
Adding version tags (v2) and adjusting wording as you suggested sounds good. 
Thank you.

Alex

Re: [Intel-wired-lan] [External] : Re: [PATCH net-next] iavf: clarify VLAN add/delete log messages and lower log level

[Przemek Kitszel]

On 11/3/25 11:30, Loktionov, Aleksandr wrote:
> 
> 
>> -----Original Message-----
>> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
>> Of ALOK TIWARI
>> Sent: Monday, November 3, 2025 11:17 AM
>> To: Kitszel, Przemyslaw <przemyslaw.kitszel@intel.com>
>> Cc: alok.a.tiwarilinux@gmail.com; Lobakin, Aleksander
>> <aleksander.lobakin@intel.com>; Nguyen, Anthony L
>> <anthony.l.nguyen@intel.com>; andrew+netdev@lunn.ch; kuba@kernel.org;
>> davem@davemloft.net; edumazet@google.com; pabeni@redhat.com;
>> horms@kernel.org; intel-wired-lan@lists.osuosl.org;
>> netdev@vger.kernel.org
>> Subject: Re: [Intel-wired-lan] [External] : Re: [PATCH net-next] iavf:
>> clarify VLAN add/delete log messages and lower log level
>>
>>
>>
>> On 11/3/2025 2:57 PM, Przemek Kitszel wrote:
>>> On 11/3/25 10:03, Alok Tiwari wrote:
>>>> The current dev_warn messages for too many VLAN changes are
>> confusing
>>>> and one place incorrectly reference "add" instead of "delete" VLANs
>>>> due to copy-paste errors.
>>>>
>>>> - Use dev_info instead of dev_warn to lower the log level.
>>>> - Rephrase the message to: "Too many VLAN [add|delete] changes
>>>> requested,
>>>>     splitting into multiple messages to PF".
>>>>
>>>> Suggested-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>>>> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
>>>
>>> thank you!
>>> just two minor nits, but the messages are good already, so:
>>> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>>>
>>>> ---
>>>> https://urldefense.com/v3/__https://lore.kernel.org/all/47f8c95c-
>>>> bac4-471f-8e58-9155c6e58cb5@intel.com/__;!!ACWV5N9M2RV99hQ!
>>>> MulRvlOtC3JAON-O816_nR2P2geYBHDIx86XOr_i1afc9gjSrXfpcVwFmP6uM0p1-
>>>> kFN64zBSLjwS3XvTDQ6nJ5R2hyIaQ$ ---
>>>>    drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 12 ++++++++----
>>>>    1 file changed, 8 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/
>>>> drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
>>>> index 34a422a4a29c..3593c0b45cf7 100644
>>>> --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
>>>> +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
>>>> @@ -793,7 +793,8 @@ void iavf_add_vlans(struct iavf_adapter
>> *adapter)
>>>>            len = virtchnl_struct_size(vvfl, vlan_id, count);
>>>>            if (len > IAVF_MAX_AQ_BUF_SIZE) {
>>>> -            dev_warn(&adapter->pdev->dev, "Too many add VLAN
>> changes
>>>> in one request\n");
>>>> +            dev_info(&adapter->pdev->dev, "Too many VLAN add
>> changes
>>>> requested,\n"
>>>> +                "splitting into multiple messages to PF\n");
>>>
>>> perhaps it is too much bikeshedding for such a change, sorry, but I
>>> would rather remove the newline in the middle
>>>
>>> nit: another thing that I would consider is to differentiate the
>>> messages (v1/v2 or A/B, or whatever) for different protocol versions
>>
>>
>> Thanks Przemek for the feedback.
>>
>> I initially had the message on a single line, but checkpatch.pl
>> reported: "WARNING: quoted string split across lines"
>>
>> To avoid that warning, I added the "\n" and split the message.
>> I can drop the newline and suppress the warning if the maintainer
>> community prefers.
>> I just wanted to stay consistent with checkpatch recommendations.
>>
>> good point, I can adjust the wording and add version tags (v1/v2) now
>> The messages currently look like this:
>>
>> dev_info(&adapter->pdev->dev, "vvfl Too many VLAN add changes
>> requested, "
>>            "splitting into multiple messages to PF\n");
>>
>> dev_info(&adapter->pdev->dev, "vvfl_v2 Too many VLAN add changes
>> requested, "
>>            "splitting into multiple messages to PF\n");
>>
>> Thanks,
>> Alok
> 
> Thanks for clarifying, Alok.
> checkpatch.pl warnings about split strings are advisory, not mandatory. For log messages, kernel style generally prefers a single, readable line rather than introducing "\n" just to silence that warning. Multi-line messages make grepping harder and are rarely needed for short text.
> So please keep the message on one line, even if that means ignoring the checkpatch warning.

there most important rule is
"do not break (split) user visible messages", and checkpatch is aware of
that. Only then is "do not go too far with characters in given line".

> 
> Something like:
> dev_info(&adapter->pdev->dev,
>           "vvfl Too many VLAN add requests; splitting into multiple messages to PF\n");
> 
> Same for the delete case. Dropping the comma for a semicolon improves clarity.
> Adding version tags (v2) and adjusting wording as you suggested sounds good.
> Thank you.
> 
> Alex