From: Petr Oros <poros@redhat.com>
To: netdev@vger.kernel.org
Cc: pmenzel@molgen.mpg.de, jesse.brandeburg@intel.com,
linux-kernel@vger.kernel.org, edumazet@google.com,
anthony.l.nguyen@intel.com, kuba@kernel.org,
intel-wired-lan@lists.osuosl.org, pabeni@redhat.com,
davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH net v2] ice: Unregister netdev and devlink_port only once
Date: Thu, 06 Jul 2023 23:30:41 +0200 [thread overview]
Message-ID: <eda7b84e56123bce167a64133572440e6806ef1e.camel@redhat.com> (raw)
In-Reply-To: <20230619105813.369912-1-poros@redhat.com>
Petr Oros píše v Po 19. 06. 2023 v 12:58 +0200:
> Since commit 6624e780a577fc ("ice: split ice_vsi_setup into smaller
> functions") ice_vsi_release does things twice. There is unregister
> netdev which is unregistered in ice_deinit_eth also.
>
> It also unregisters the devlink_port twice which is also unregistered
> in ice_deinit_eth(). This double deregistration is hidden because
> devl_port_unregister ignores the return value of xa_erase.
>
Hi,
Is it possible to push this patch forward? I think the questions have
been answered. Or is something still unclear?
Regards,
Petr
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-07-06 21:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 10:58 [Intel-wired-lan] [PATCH net v2] ice: Unregister netdev and devlink_port only once Petr Oros
2023-06-19 15:07 ` Jiri Pirko
2023-06-20 7:55 ` Maciej Fijalkowski
2023-06-20 7:50 ` Maciej Fijalkowski
2023-07-06 21:30 ` Petr Oros [this message]
2023-07-07 17:03 ` Tony Nguyen
2023-07-14 8:59 ` Pucha, HimasekharX Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eda7b84e56123bce167a64133572440e6806ef1e.camel@redhat.com \
--to=poros@redhat.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox