From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Mateusz Palczewski <mateusz.palczewski@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: Michal Jaron <michalx.jaron@intel.com>,
Slawomir Laba <slawomirx.laba@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH net v1 1/2] i40e: Fix ethtool rx-flow-hash setting for X722
Date: Mon, 11 Jul 2022 16:22:19 -0700 [thread overview]
Message-ID: <f11b20bd-8bd0-5fbf-adab-d037c0a4c816@intel.com> (raw)
In-Reply-To: <20220704074359.1221497-1-mateusz.palczewski@intel.com>
On 7/4/2022 12:43 AM, Mateusz Palczewski wrote:
> From: Michal Jaron <michalx.jaron@intel.com>
>
> When enabling flow type for RSS hash via ethtool:
>
> ethtool -N $pf rx-flow-hash tcp4|tcp6|udp4|udp6 s|d
>
> the driver would fail to setup this setting on X722
> device since it was using the mask on the register
> dedicated for X710 devices.
>
> Implement a bitmap to collect the flow pc types that
> shall be applied on the inset and hena registers.
Isn't this in patch 2 now?
> Apply a different mask on the register when setting the
> RSS hash for the X722 device.
>
> When displaying the flow types enabled via ethtool:
>
> ethtool -n $pf rx-flow-hash tcp4|tcp6|udp4|udp6
>
> the driver would print wrong values for X722 device.
>
> Fix this issue by testing masks for X722 device in
> i40e_get_rss_hash_opts function.
>
> Fixes: eb0dd6e4a3b3 (i40e: Allow RSS Hash set with less than four parameters)
> Signed-off-by: Michal Jaron <michalx.jaron@intel.com>
> Signed-off-by: Slawomir Laba <slawomirx.laba@intel.com>
> Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>
> ---
<snip>
> @@ -3464,7 +3471,9 @@ static int i40e_get_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *cmd,
> *
> * Returns value of bits to be set per user request
> **/
> -static u64 i40e_get_rss_hash_bits(struct ethtool_rxnfc *nfc, u64 i_setc)
> +static u64 i40e_get_rss_hash_bits(struct i40e_hw *hw,
> + struct ethtool_rxnfc *nfc,
> + u64 i_setc)
kdoc needs to be updated:
drivers/net/ethernet/intel/i40e/i40e_ethtool.c:3477: warning: Function
parameter or member 'hw' not described in 'i40e_get_rss_hash_bits'
> {
> u64 i_set = i_setc;
> u64 src_l3 = 0, dst_l3 = 0;
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
prev parent reply other threads:[~2022-07-11 23:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 7:43 [Intel-wired-lan] [PATCH net v1 1/2] i40e: Fix ethtool rx-flow-hash setting for X722 Mateusz Palczewski
2022-07-11 23:22 ` Tony Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f11b20bd-8bd0-5fbf-adab-d037c0a4c816@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=mateusz.palczewski@intel.com \
--cc=michalx.jaron@intel.com \
--cc=slawomirx.laba@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox