* [Intel-wired-lan] [PATCH v1 3/3] e1000e: Additional PHY power saving in s0ix
@ 2021-06-24 8:19 Sasha Neftin
2021-07-13 7:04 ` Fuxbrumer, Dvora
2021-07-13 7:12 ` Paul Menzel
0 siblings, 2 replies; 6+ messages in thread
From: Sasha Neftin @ 2021-06-24 8:19 UTC (permalink / raw)
To: intel-wired-lan
After transferring the MAC-PHY interface to the SMBus the PHY
will save power in S0ix low power idle mode.
Suggested-by: Dima Ruinskiy <dima.ruinskiy@intel.com>
Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
---
drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index 6e6e2e685e9d..c4f3e5ca7294 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -6380,10 +6380,16 @@ static void e1000e_s0ix_entry_flow(struct e1000_adapter *adapter)
ew32(CTRL_EXT, mac_data);
/* DFT control: PHY bit: page769_20[0] = 1
+ * page769_20[7] - PHY PLL stop
+ * page769_20[8] - PHY go to the electrical idle
+ * page769_20[9] - PHY serdes disable
* Gate PPW via EXTCNF_CTRL - set 0x0F00[7] = 1
*/
e1e_rphy(hw, I82579_DFT_CTRL, &phy_data);
phy_data |= BIT(0);
+ phy_data |= BIT(7);
+ phy_data |= BIT(8);
+ phy_data |= BIT(9);
e1e_wphy(hw, I82579_DFT_CTRL, phy_data);
mac_data = er32(EXTCNF_CTRL);
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-wired-lan] [PATCH v1 3/3] e1000e: Additional PHY power saving in s0ix
2021-06-24 8:19 [Intel-wired-lan] [PATCH v1 3/3] e1000e: Additional PHY power saving in s0ix Sasha Neftin
@ 2021-07-13 7:04 ` Fuxbrumer, Dvora
2021-07-13 7:12 ` Paul Menzel
1 sibling, 0 replies; 6+ messages in thread
From: Fuxbrumer, Dvora @ 2021-07-13 7:04 UTC (permalink / raw)
To: intel-wired-lan
On 6/24/2021 11:19, Sasha Neftin wrote:
> After transferring the MAC-PHY interface to the SMBus the PHY
> will save power in S0ix low power idle mode.
>
> Suggested-by: Dima Ruinskiy <dima.ruinskiy@intel.com>
> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
> ---
> drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
Tested-by: Dvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-wired-lan] [PATCH v1 3/3] e1000e: Additional PHY power saving in s0ix
2021-06-24 8:19 [Intel-wired-lan] [PATCH v1 3/3] e1000e: Additional PHY power saving in s0ix Sasha Neftin
2021-07-13 7:04 ` Fuxbrumer, Dvora
@ 2021-07-13 7:12 ` Paul Menzel
2021-07-13 16:40 ` Sasha Neftin
1 sibling, 1 reply; 6+ messages in thread
From: Paul Menzel @ 2021-07-13 7:12 UTC (permalink / raw)
To: intel-wired-lan
Dear Sasha, dear Dima,
Am 24.06.21 um 10:19 schrieb Sasha Neftin:
Could you please use a statement in the commit message summary? Maybe:
> Disable additional PHY features(?) in S0ix
> After transferring the MAC-PHY interface to the SMBus the PHY
> will save power in S0ix low power idle mode.
I do not understand this. Please rewrite, and mention the three PHY
features(?) you change.
Please document how you tested this, and exactly how much power is saved.
> Suggested-by: Dima Ruinskiy <dima.ruinskiy@intel.com>
> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
> ---
> drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
> index 6e6e2e685e9d..c4f3e5ca7294 100644
> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
> @@ -6380,10 +6380,16 @@ static void e1000e_s0ix_entry_flow(struct e1000_adapter *adapter)
> ew32(CTRL_EXT, mac_data);
>
> /* DFT control: PHY bit: page769_20[0] = 1
> + * page769_20[7] - PHY PLL stop
> + * page769_20[8] - PHY go to the electrical idle
> + * page769_20[9] - PHY serdes disable
> * Gate PPW via EXTCNF_CTRL - set 0x0F00[7] = 1
> */
> e1e_rphy(hw, I82579_DFT_CTRL, &phy_data);
> phy_data |= BIT(0);
> + phy_data |= BIT(7);
> + phy_data |= BIT(8);
> + phy_data |= BIT(9);
> e1e_wphy(hw, I82579_DFT_CTRL, phy_data);
>
> mac_data = er32(EXTCNF_CTRL);
>
Kind regards,
Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-wired-lan] [PATCH v1 3/3] e1000e: Additional PHY power saving in s0ix
2021-07-13 7:12 ` Paul Menzel
@ 2021-07-13 16:40 ` Sasha Neftin
2021-07-14 6:09 ` Paul Menzel
0 siblings, 1 reply; 6+ messages in thread
From: Sasha Neftin @ 2021-07-13 16:40 UTC (permalink / raw)
To: intel-wired-lan
On 7/13/2021 10:12, Paul Menzel wrote:
> Dear Sasha, dear Dima,
>
>
> Am 24.06.21 um 10:19 schrieb Sasha Neftin:
>
> Could you please use a statement in the commit message summary? Maybe:
>
>> Disable additional PHY features(?) in S0ix
>
>> After transferring the MAC-PHY interface to the SMBus the PHY
>> will save power in S0ix low power idle mode.
>
> I do not understand this. Please rewrite, and mention the three PHY
> features(?) you change.
>
> Please document how you tested this, and exactly how much power is saved.
Dear Paul,
The PHY will save 47-85mW in s0ix. It is tested (by our electrical
validation team) on a sense resistor on a specific external board over
the TGL platform.
This measurement could variate from platform to platform and depends on
the specific platform design.
>
>> Suggested-by: Dima Ruinskiy <dima.ruinskiy@intel.com>
>> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
>> ---
>> ? drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++
>> ? 1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c
>> b/drivers/net/ethernet/intel/e1000e/netdev.c
>> index 6e6e2e685e9d..c4f3e5ca7294 100644
>> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
>> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
>> @@ -6380,10 +6380,16 @@ static void e1000e_s0ix_entry_flow(struct
>> e1000_adapter *adapter)
>> ????????? ew32(CTRL_EXT, mac_data);
>> ? ????????? /* DFT control: PHY bit: page769_20[0] = 1
>> +???????? * page769_20[7] - PHY PLL stop
>> +???????? * page769_20[8] - PHY go to the electrical idle
>> +???????? * page769_20[9] - PHY serdes disable
>> ?????????? * Gate PPW via EXTCNF_CTRL - set 0x0F00[7] = 1
>> ?????????? */
>> ????????? e1e_rphy(hw, I82579_DFT_CTRL, &phy_data);
>> ????????? phy_data |= BIT(0);
>> +??????? phy_data |= BIT(7);
>> +??????? phy_data |= BIT(8);
>> +??????? phy_data |= BIT(9);
>> ????????? e1e_wphy(hw, I82579_DFT_CTRL, phy_data);
>> ? ????????? mac_data = er32(EXTCNF_CTRL);
>>
>
>
> Kind regards,
>
> Paul
Thanks,
Sasha
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20210713/4f209781/attachment-0001.html>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-wired-lan] [PATCH v1 3/3] e1000e: Additional PHY power saving in s0ix
2021-07-13 16:40 ` Sasha Neftin
@ 2021-07-14 6:09 ` Paul Menzel
2021-07-14 7:04 ` Sasha Neftin
0 siblings, 1 reply; 6+ messages in thread
From: Paul Menzel @ 2021-07-14 6:09 UTC (permalink / raw)
To: intel-wired-lan
Dear Sasha,
Am 13.07.21 um 18:40 schrieb Sasha Neftin:
> On 7/13/2021 10:12, Paul Menzel wrote:
>> Am 24.06.21 um 10:19 schrieb Sasha Neftin:
>>
>> Could you please use a statement in the commit message summary? Maybe:
>>
>>> Disable additional PHY features(?) in S0ix
>>
>>> After transferring the MAC-PHY interface to the SMBus the PHY
>>> will save power in S0ix low power idle mode.
>>
>> I do not understand this. Please rewrite, and mention the three PHY
>> features(?) you change.
>>
>> Please document how you tested this, and exactly how much power is saved.
> The PHY will save 47-85mW in s0ix. It is tested (by our electrical
> validation team) on a sense resistor on a specific external board over
> the TGL platform.
>
> This measurement could variate from platform to platform and depends on
> the specific platform design.
Thank you for sharing the data. Please add it to the commit message in v2.
>>> Suggested-by: Dima Ruinskiy <dima.ruinskiy@intel.com>
>>> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
>>> ---
>>> ? drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++
>>> ? 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c
>>> b/drivers/net/ethernet/intel/e1000e/netdev.c
>>> index 6e6e2e685e9d..c4f3e5ca7294 100644
>>> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
>>> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
>>> @@ -6380,10 +6380,16 @@ static void e1000e_s0ix_entry_flow(struct
>>> e1000_adapter *adapter)
>>> ????????? ew32(CTRL_EXT, mac_data);
>>> ? ????????? /* DFT control: PHY bit: page769_20[0] = 1
>>> +???????? * page769_20[7] - PHY PLL stop
>>> +???????? * page769_20[8] - PHY go to the electrical idle
>>> +???????? * page769_20[9] - PHY serdes disable
>>> ?????????? * Gate PPW via EXTCNF_CTRL - set 0x0F00[7] = 1
>>> ?????????? */
>>> ????????? e1e_rphy(hw, I82579_DFT_CTRL, &phy_data);
>>> ????????? phy_data |= BIT(0);
>>> +??????? phy_data |= BIT(7);
>>> +??????? phy_data |= BIT(8);
>>> +??????? phy_data |= BIT(9);
>>> ????????? e1e_wphy(hw, I82579_DFT_CTRL, phy_data);
>>> ? ????????? mac_data = er32(EXTCNF_CTRL);
>>>
Kind regards,
Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-wired-lan] [PATCH v1 3/3] e1000e: Additional PHY power saving in s0ix
2021-07-14 6:09 ` Paul Menzel
@ 2021-07-14 7:04 ` Sasha Neftin
0 siblings, 0 replies; 6+ messages in thread
From: Sasha Neftin @ 2021-07-14 7:04 UTC (permalink / raw)
To: intel-wired-lan
On 7/14/2021 09:09, Paul Menzel wrote:
> Dear Sasha,
>
>
> Am 13.07.21 um 18:40 schrieb Sasha Neftin:
>> On 7/13/2021 10:12, Paul Menzel wrote:
>
>>> Am 24.06.21 um 10:19 schrieb Sasha Neftin:
>>>
>>> Could you please use a statement in the commit message summary? Maybe:
>>>
>>>> Disable additional PHY features(?) in S0ix
>>>
>>>> After transferring the MAC-PHY interface to the SMBus the PHY
>>>> will save power in S0ix low power idle mode.
>>>
>>> I do not understand this. Please rewrite, and mention the three PHY
>>> features(?) you change.
>>>
>>> Please document how you tested this, and exactly how much power is
>>> saved.
>
>> The PHY will save 47-85mW in s0ix. It is tested (by our electrical
>> validation team) on a sense resistor on a specific external board over
>> the TGL platform.
>>
>> This measurement could variate from platform to platform and depends
>> on the specific platform design.
>
> Thank you for sharing the data. Please add it to the commit message in v2.
Paul, I will work on this with our HW architect. We will process
specification updates. I will let you know and share since it will ready.
>
>>>> Suggested-by: Dima Ruinskiy <dima.ruinskiy@intel.com>
>>>> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
>>>> ---
>>>> ? drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++
>>>> ? 1 file changed, 6 insertions(+)
>>>>
>>>> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c
>>>> b/drivers/net/ethernet/intel/e1000e/netdev.c
>>>> index 6e6e2e685e9d..c4f3e5ca7294 100644
>>>> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
>>>> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
>>>> @@ -6380,10 +6380,16 @@ static void e1000e_s0ix_entry_flow(struct
>>>> e1000_adapter *adapter)
>>>> ????????? ew32(CTRL_EXT, mac_data);
>>>> ? ????????? /* DFT control: PHY bit: page769_20[0] = 1
>>>> +???????? * page769_20[7] - PHY PLL stop
>>>> +???????? * page769_20[8] - PHY go to the electrical idle
>>>> +???????? * page769_20[9] - PHY serdes disable
>>>> ?????????? * Gate PPW via EXTCNF_CTRL - set 0x0F00[7] = 1
>>>> ?????????? */
>>>> ????????? e1e_rphy(hw, I82579_DFT_CTRL, &phy_data);
>>>> ????????? phy_data |= BIT(0);
>>>> +??????? phy_data |= BIT(7);
>>>> +??????? phy_data |= BIT(8);
>>>> +??????? phy_data |= BIT(9);
>>>> ????????? e1e_wphy(hw, I82579_DFT_CTRL, phy_data);
>>>> ? ????????? mac_data = er32(EXTCNF_CTRL);
>>>>
>
>
> Kind regards,
>
> Paul
Sasha
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-07-14 7:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-24 8:19 [Intel-wired-lan] [PATCH v1 3/3] e1000e: Additional PHY power saving in s0ix Sasha Neftin
2021-07-13 7:04 ` Fuxbrumer, Dvora
2021-07-13 7:12 ` Paul Menzel
2021-07-13 16:40 ` Sasha Neftin
2021-07-14 6:09 ` Paul Menzel
2021-07-14 7:04 ` Sasha Neftin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox