Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kraus, NechamaX <nechamax.kraus@linux.intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v1 1/1] igc: Fix typo in i225 LTR functions
Date: Thu, 4 Nov 2021 11:09:53 +0200	[thread overview]
Message-ID: <f63baf1e-6fa6-9a9b-a78f-a84e08adad9b@linux.intel.com> (raw)
In-Reply-To: <20211102072006.2757474-1-sasha.neftin@intel.com>

On 11/2/2021 09:20, Sasha Neftin wrote:
> The LTR maximum value was incorrectly written using the scale from
> the LTR minimum value. This would cause incorrect values to be sent,
> in cases where the initial calculation lead to different min/max scales.
> 
> Suggested-by: Dima Ruinskiy <dima.ruinskiy@intel.com>
> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_i225.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc_i225.c b/drivers/net/ethernet/intel/igc/igc_i225.c
> index b2ef9fde97b3..b6807e16eea9 100644
> --- a/drivers/net/ethernet/intel/igc/igc_i225.c
> +++ b/drivers/net/ethernet/intel/igc/igc_i225.c
> @@ -636,7 +636,7 @@ s32 igc_set_ltr_i225(struct igc_hw *hw, bool link)
>   		ltrv = rd32(IGC_LTRMAXV);
>   		if (ltr_max != (ltrv & IGC_LTRMAXV_LTRV_MASK)) {
>   			ltrv = IGC_LTRMAXV_LSNP_REQ | ltr_max |
> -			       (scale_min << IGC_LTRMAXV_SCALE_SHIFT);
> +			       (scale_max << IGC_LTRMAXV_SCALE_SHIFT);
>   			wr32(IGC_LTRMAXV, ltrv);
>   		}
>   	}
> 
Tested-by: Nechama Kraus <nechamax.kraus@linux.intel.com>

      reply	other threads:[~2021-11-04  9:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-02  7:20 [Intel-wired-lan] [PATCH v1 1/1] igc: Fix typo in i225 LTR functions Sasha Neftin
2021-11-04  9:09 ` Kraus, NechamaX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f63baf1e-6fa6-9a9b-a78f-a84e08adad9b@linux.intel.com \
    --to=nechamax.kraus@linux.intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox