* [Intel-wired-lan] [PATCH v1 1/1] igc: Fix typo in i225 LTR functions
@ 2021-11-02 7:20 Sasha Neftin
2021-11-04 9:09 ` Kraus, NechamaX
0 siblings, 1 reply; 2+ messages in thread
From: Sasha Neftin @ 2021-11-02 7:20 UTC (permalink / raw)
To: intel-wired-lan
The LTR maximum value was incorrectly written using the scale from
the LTR minimum value. This would cause incorrect values to be sent,
in cases where the initial calculation lead to different min/max scales.
Suggested-by: Dima Ruinskiy <dima.ruinskiy@intel.com>
Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
---
drivers/net/ethernet/intel/igc/igc_i225.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_i225.c b/drivers/net/ethernet/intel/igc/igc_i225.c
index b2ef9fde97b3..b6807e16eea9 100644
--- a/drivers/net/ethernet/intel/igc/igc_i225.c
+++ b/drivers/net/ethernet/intel/igc/igc_i225.c
@@ -636,7 +636,7 @@ s32 igc_set_ltr_i225(struct igc_hw *hw, bool link)
ltrv = rd32(IGC_LTRMAXV);
if (ltr_max != (ltrv & IGC_LTRMAXV_LTRV_MASK)) {
ltrv = IGC_LTRMAXV_LSNP_REQ | ltr_max |
- (scale_min << IGC_LTRMAXV_SCALE_SHIFT);
+ (scale_max << IGC_LTRMAXV_SCALE_SHIFT);
wr32(IGC_LTRMAXV, ltrv);
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Intel-wired-lan] [PATCH v1 1/1] igc: Fix typo in i225 LTR functions
2021-11-02 7:20 [Intel-wired-lan] [PATCH v1 1/1] igc: Fix typo in i225 LTR functions Sasha Neftin
@ 2021-11-04 9:09 ` Kraus, NechamaX
0 siblings, 0 replies; 2+ messages in thread
From: Kraus, NechamaX @ 2021-11-04 9:09 UTC (permalink / raw)
To: intel-wired-lan
On 11/2/2021 09:20, Sasha Neftin wrote:
> The LTR maximum value was incorrectly written using the scale from
> the LTR minimum value. This would cause incorrect values to be sent,
> in cases where the initial calculation lead to different min/max scales.
>
> Suggested-by: Dima Ruinskiy <dima.ruinskiy@intel.com>
> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc_i225.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_i225.c b/drivers/net/ethernet/intel/igc/igc_i225.c
> index b2ef9fde97b3..b6807e16eea9 100644
> --- a/drivers/net/ethernet/intel/igc/igc_i225.c
> +++ b/drivers/net/ethernet/intel/igc/igc_i225.c
> @@ -636,7 +636,7 @@ s32 igc_set_ltr_i225(struct igc_hw *hw, bool link)
> ltrv = rd32(IGC_LTRMAXV);
> if (ltr_max != (ltrv & IGC_LTRMAXV_LTRV_MASK)) {
> ltrv = IGC_LTRMAXV_LSNP_REQ | ltr_max |
> - (scale_min << IGC_LTRMAXV_SCALE_SHIFT);
> + (scale_max << IGC_LTRMAXV_SCALE_SHIFT);
> wr32(IGC_LTRMAXV, ltrv);
> }
> }
>
Tested-by: Nechama Kraus <nechamax.kraus@linux.intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-04 9:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-02 7:20 [Intel-wired-lan] [PATCH v1 1/1] igc: Fix typo in i225 LTR functions Sasha Neftin
2021-11-04 9:09 ` Kraus, NechamaX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox