From: "Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
<intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH 1/3] drm/xe: Fix register definition order in xe_regs.h
Date: Thu, 4 Jul 2024 08:47:21 +0530 [thread overview]
Message-ID: <03ee425e-bf6e-40fa-8f57-61bd667e46ea@intel.com> (raw)
In-Reply-To: <20240702183704.1022-2-michal.wajdeczko@intel.com>
On 03-07-2024 00:07, Michal Wajdeczko wrote:
> Swap XEHP_CLOCK_GATE_DIS(0x101014) with GU_DEBUG(x101018).
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
> drivers/gpu/drm/xe/regs/xe_regs.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/regs/xe_regs.h b/drivers/gpu/drm/xe/regs/xe_regs.h
> index 23e33ec84902..23ecba38ed41 100644
> --- a/drivers/gpu/drm/xe/regs/xe_regs.h
> +++ b/drivers/gpu/drm/xe/regs/xe_regs.h
> @@ -24,12 +24,12 @@
> #define LMEM_INIT REG_BIT(7)
> #define DRIVERFLR REG_BIT(31)
>
> -#define GU_DEBUG XE_REG(0x101018)
> -#define DRIVERFLR_STATUS REG_BIT(31)
> -
> #define XEHP_CLOCK_GATE_DIS XE_REG(0x101014)
> #define SGSI_SIDECLK_DIS REG_BIT(17)
>
> +#define GU_DEBUG XE_REG(0x101018)
> +#define DRIVERFLR_STATUS REG_BIT(31)
LGTM
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> +
> #define XEHP_MTCFG_ADDR XE_REG(0x101800)
> #define TILE_COUNT REG_GENMASK(15, 8)
>
next prev parent reply other threads:[~2024-07-04 3:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 18:37 [PATCH 0/3] drm/xe: Use VF_CAP_REG for device wmb Michal Wajdeczko
2024-07-02 18:37 ` [PATCH 1/3] drm/xe: Fix register definition order in xe_regs.h Michal Wajdeczko
2024-07-04 3:17 ` Ghimiray, Himal Prasad [this message]
2024-07-02 18:37 ` [PATCH 2/3] drm/xe: Kill regs/xe_sriov_regs.h Michal Wajdeczko
2024-07-04 3:17 ` Ghimiray, Himal Prasad
2024-07-02 18:37 ` [PATCH 3/3] drm/xe: Use VF_CAP_REG for device wmb Michal Wajdeczko
2024-07-04 4:01 ` Ghimiray, Himal Prasad
2024-08-26 23:24 ` Dixit, Ashutosh
2024-08-27 21:05 ` Michal Wajdeczko
2024-07-02 22:13 ` [PATCH 0/3] " Matt Roper
2024-07-03 13:22 ` ✓ CI.Patch_applied: success for " Patchwork
2024-07-03 13:22 ` ✗ CI.checkpatch: warning " Patchwork
2024-07-03 13:23 ` ✓ CI.KUnit: success " Patchwork
2024-07-03 13:35 ` ✓ CI.Build: " Patchwork
2024-07-03 13:38 ` ✓ CI.Hooks: " Patchwork
2024-07-03 13:39 ` ✓ CI.checksparse: " Patchwork
2024-07-03 14:05 ` ✓ CI.BAT: " Patchwork
2024-07-03 17:52 ` ✗ CI.FULL: failure " Patchwork
2024-07-03 19:42 ` Michal Wajdeczko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03ee425e-bf6e-40fa-8f57-61bd667e46ea@intel.com \
--to=himal.prasad.ghimiray@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox