From: "Govindapillai, Vinod" <vinod.govindapillai@intel.com>
To: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Cc: "Saarinen, Jani" <jani.saarinen@intel.com>,
"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
"Nikula, Jani" <jani.nikula@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v10 2/9] drm/damage-helper: add const qualifier in drm_atomic_helper_damage_merged()
Date: Sun, 2 Mar 2025 08:47:32 +0000 [thread overview]
Message-ID: <06cd451eaf2c8a2d3567d272b3ca75228ccc9988.camel@intel.com> (raw)
In-Reply-To: <20250228093802.27091-3-vinod.govindapillai@intel.com>
Hello drm maintainers,
Could you please Ack this patch to get this merged through drm-intel-next..
Thanks
Vinod
On Fri, 2025-02-28 at 11:37 +0200, Vinod Govindapillai wrote:
> Add a const qualifier for the "state" parameter as well as we could
> use this helper to get the combined damage in cases of const
> drm_plane_state as well. Needed mainly for xe driver big joiner cases
> where we need to track the damage from immutable plane state.
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
> ---
> drivers/gpu/drm/drm_damage_helper.c | 2 +-
> include/drm/drm_damage_helper.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_damage_helper.c b/drivers/gpu/drm/drm_damage_helper.c
> index afb02aae707b..44a5a36806e3 100644
> --- a/drivers/gpu/drm/drm_damage_helper.c
> +++ b/drivers/gpu/drm/drm_damage_helper.c
> @@ -308,7 +308,7 @@ EXPORT_SYMBOL(drm_atomic_helper_damage_iter_next);
> * True if there is valid plane damage otherwise false.
> */
> bool drm_atomic_helper_damage_merged(const struct drm_plane_state *old_state,
> - struct drm_plane_state *state,
> + const struct drm_plane_state *state,
> struct drm_rect *rect)
> {
> struct drm_atomic_helper_damage_iter iter;
> diff --git a/include/drm/drm_damage_helper.h b/include/drm/drm_damage_helper.h
> index effda42cce31..a58cbcd11276 100644
> --- a/include/drm/drm_damage_helper.h
> +++ b/include/drm/drm_damage_helper.h
> @@ -78,7 +78,7 @@ bool
> drm_atomic_helper_damage_iter_next(struct drm_atomic_helper_damage_iter *iter,
> struct drm_rect *rect);
> bool drm_atomic_helper_damage_merged(const struct drm_plane_state *old_state,
> - struct drm_plane_state *state,
> + const struct drm_plane_state *state,
> struct drm_rect *rect);
>
> #endif
next prev parent reply other threads:[~2025-03-02 8:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 9:37 [PATCH v10 0/9] [PATCH v9 0/8] drm/i915/fbc: FBC Dirty rect feature support Vinod Govindapillai
2025-02-28 9:37 ` [PATCH v10 1/9] drm/i915/fbc: remove one duplicate forward declaration Vinod Govindapillai
2025-02-28 9:43 ` Jani Nikula
2025-02-28 9:37 ` [PATCH v10 2/9] drm/damage-helper: add const qualifier in drm_atomic_helper_damage_merged() Vinod Govindapillai
2025-03-02 8:47 ` Govindapillai, Vinod [this message]
2025-03-03 9:16 ` Jani Nikula
2025-02-28 9:37 ` [PATCH v10 3/9] drm/i915/display: update and store the plane damage clips Vinod Govindapillai
2025-02-28 9:37 ` [PATCH v10 4/9] drm/i915/fbc: add register definitions for fbc dirty rect support Vinod Govindapillai
2025-02-28 9:37 ` [PATCH v10 5/9] drm/i915/fbc: introduce HAS_FBC_DIRTY_RECT() for FBC " Vinod Govindapillai
2025-02-28 9:37 ` [PATCH v10 6/9] drm/i915/fbc: avoid calling fbc activate if fbc is active Vinod Govindapillai
2025-02-28 9:38 ` [PATCH v10 7/9] drm/i915/fbc: dirty rect support for FBC Vinod Govindapillai
2025-02-28 9:38 ` [PATCH v10 8/9] drm/i915/fbc: disable FBC if PSR2 selective fetch is enabled Vinod Govindapillai
2025-02-28 9:38 ` [PATCH v10 9/9] drm/i915/fbc: handle dirty rect coords for the first frame Vinod Govindapillai
2025-02-28 11:13 ` ✓ CI.Patch_applied: success for drm/i915/fbc: FBC Dirty rect feature support (rev4) Patchwork
2025-02-28 11:14 ` ✗ CI.checkpatch: warning " Patchwork
2025-02-28 11:16 ` ✓ CI.KUnit: success " Patchwork
2025-02-28 11:37 ` ✓ CI.Build: " Patchwork
2025-02-28 11:39 ` ✓ CI.Hooks: " Patchwork
2025-02-28 11:41 ` ✗ CI.checksparse: warning " Patchwork
2025-02-28 12:00 ` ✓ Xe.CI.BAT: success " Patchwork
2025-02-28 17:19 ` ✗ Xe.CI.Full: failure " Patchwork
2025-02-28 18:11 ` Govindapillai, Vinod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06cd451eaf2c8a2d3567d272b3ca75228ccc9988.camel@intel.com \
--to=vinod.govindapillai@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jani.saarinen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox