From: Vinod Govindapillai <vinod.govindapillai@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org, vinod.govindapillai@intel.com,
jani.nikula@intel.com, jani.saarinen@intel.com
Subject: [PATCH v10 8/9] drm/i915/fbc: disable FBC if PSR2 selective fetch is enabled
Date: Fri, 28 Feb 2025 11:38:01 +0200 [thread overview]
Message-ID: <20250228093802.27091-9-vinod.govindapillai@intel.com> (raw)
In-Reply-To: <20250228093802.27091-1-vinod.govindapillai@intel.com>
It is not recommended to have both FBC dirty rect and PSR2
selective fetch be enabled at the same time. Mark FBC as not
possible, if PSR2 selective fetch is enabled.
v2: fix the condition to disable FBC if PSR2 enabled (Jani)
v3: use HAS_FBC_DIRTY_RECT()
v4: Update to patch description
Bspec: 68881
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
drivers/gpu/drm/i915/display/intel_fbc.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
index ee2d75303e41..5b6a9315fa8f 100644
--- a/drivers/gpu/drm/i915/display/intel_fbc.c
+++ b/drivers/gpu/drm/i915/display/intel_fbc.c
@@ -1415,9 +1415,14 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state,
* Display 12+ is not supporting FBC with PSR2.
* Recommendation is to keep this combination disabled
* Bspec: 50422 HSD: 14010260002
+ *
+ * In Xe3, PSR2 selective fetch and FBC dirty rect feature cannot
+ * coexist. So if PSR2 selective fetch is supported then mark that
+ * FBC is not supported.
+ * TODO: Need a logic to decide between PSR2 and FBC Dirty rect
*/
- if (IS_DISPLAY_VER(display, 12, 14) && crtc_state->has_sel_update &&
- !crtc_state->has_panel_replay) {
+ if ((IS_DISPLAY_VER(display, 12, 14) || HAS_FBC_DIRTY_RECT(display)) &&
+ crtc_state->has_sel_update && !crtc_state->has_panel_replay) {
plane_state->no_fbc_reason = "PSR2 enabled";
return 0;
}
--
2.43.0
next prev parent reply other threads:[~2025-02-28 9:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 9:37 [PATCH v10 0/9] [PATCH v9 0/8] drm/i915/fbc: FBC Dirty rect feature support Vinod Govindapillai
2025-02-28 9:37 ` [PATCH v10 1/9] drm/i915/fbc: remove one duplicate forward declaration Vinod Govindapillai
2025-02-28 9:43 ` Jani Nikula
2025-02-28 9:37 ` [PATCH v10 2/9] drm/damage-helper: add const qualifier in drm_atomic_helper_damage_merged() Vinod Govindapillai
2025-03-02 8:47 ` Govindapillai, Vinod
2025-03-03 9:16 ` Jani Nikula
2025-02-28 9:37 ` [PATCH v10 3/9] drm/i915/display: update and store the plane damage clips Vinod Govindapillai
2025-02-28 9:37 ` [PATCH v10 4/9] drm/i915/fbc: add register definitions for fbc dirty rect support Vinod Govindapillai
2025-02-28 9:37 ` [PATCH v10 5/9] drm/i915/fbc: introduce HAS_FBC_DIRTY_RECT() for FBC " Vinod Govindapillai
2025-02-28 9:37 ` [PATCH v10 6/9] drm/i915/fbc: avoid calling fbc activate if fbc is active Vinod Govindapillai
2025-02-28 9:38 ` [PATCH v10 7/9] drm/i915/fbc: dirty rect support for FBC Vinod Govindapillai
2025-02-28 9:38 ` Vinod Govindapillai [this message]
2025-02-28 9:38 ` [PATCH v10 9/9] drm/i915/fbc: handle dirty rect coords for the first frame Vinod Govindapillai
2025-02-28 11:13 ` ✓ CI.Patch_applied: success for drm/i915/fbc: FBC Dirty rect feature support (rev4) Patchwork
2025-02-28 11:14 ` ✗ CI.checkpatch: warning " Patchwork
2025-02-28 11:16 ` ✓ CI.KUnit: success " Patchwork
2025-02-28 11:37 ` ✓ CI.Build: " Patchwork
2025-02-28 11:39 ` ✓ CI.Hooks: " Patchwork
2025-02-28 11:41 ` ✗ CI.checksparse: warning " Patchwork
2025-02-28 12:00 ` ✓ Xe.CI.BAT: success " Patchwork
2025-02-28 17:19 ` ✗ Xe.CI.Full: failure " Patchwork
2025-02-28 18:11 ` Govindapillai, Vinod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250228093802.27091-9-vinod.govindapillai@intel.com \
--to=vinod.govindapillai@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jani.saarinen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox