Re: [PATCH 3/3] drm/xe: Drop duplicated information about GT tile in devcoredump

[John Harrison <john.c.harrison@intel.com>]

On 1/23/2025 09:59, José Roberto de Souza wrote:
> The GT tile is already available but was added again in commit
> c28fd6c358db ("drm/xe/devcoredump: Improve section headings and add tile info"),
> so here deleting it.
>
> Here a devcoredump example with the duplicated information:
>
> **** Xe Device Coredump ****
> Reason: Timedout job - seqno=4294967170, lrc_seqno=4294967170, guc_id=13, flags=0x0
> kernel: 6.13.0-zeh-xe+
> module: xe
> Snapshot time: 1737573530.243521319
> Uptime: 2588.041930284
> Process: deqp-vk [8850]
> PCI ID: 0x64a0
> PCI revision: 0x04
> GT id: 0
> 	Tile: 0
> 	Type: main
> 	IP ver: 20.4.4
> 	CS reference clock: 19200000
> GT id: 1
> 	Tile: 0
> 	Type: media
> 	IP ver: 20.0.4
> 	CS reference clock: 19200000
This is an overview of all GTs/tiles in the device within the global 
section.

>
> **** GT #0 ****
This is a section header telling you that everything which follows is 
inside GT0.

It is not duplicated information. And if you remove it then you now have 
the information of all GTs back to back with no indication of which GT 
they actually belong to.

John.


> 	Tile: 0
>
> **** GuC Log ****
> ....
>
> Cc: John Harrison <John.C.Harrison@Intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_devcoredump.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_devcoredump.c b/drivers/gpu/drm/xe/xe_devcoredump.c
> index 1c86e6456d60f..2996945ffee39 100644
> --- a/drivers/gpu/drm/xe/xe_devcoredump.c
> +++ b/drivers/gpu/drm/xe/xe_devcoredump.c
> @@ -111,9 +111,6 @@ static ssize_t __xe_devcoredump_read(char *buffer, size_t count,
>   	drm_printf(&p, "Process: %s [%d]\n", ss->process_name, ss->pid);
>   	xe_device_snapshot_print(xe, &p);
>   
> -	drm_printf(&p, "\n**** GT #%d ****\n", ss->gt->info.id);
> -	drm_printf(&p, "\tTile: %d\n", ss->gt->tile->id);
> -
>   	drm_puts(&p, "\n**** GuC Log ****\n");
>   	xe_guc_log_snapshot_print(ss->guc.log, &p);
>   	drm_puts(&p, "\n**** GuC CT ****\n");