From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>,
<intel-gfx@lists.freedesktop.org>,
<intel-xe@lists.freedesktop.org>
Cc: <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v2 04/13] drm/i915/vrr: Add enable/disable calls for DC Balance
Date: Wed, 23 Apr 2025 12:31:49 +0530 [thread overview]
Message-ID: <0abc19ec-ff48-4a2c-b347-598fba194bca@intel.com> (raw)
In-Reply-To: <20250421154900.2095202-5-mitulkumar.ajitkumar.golani@intel.com>
On 4/21/2025 9:18 PM, Mitul Golani wrote:
> Add enable/disable calls along with required hw registers
> for DC balance enablement.
>
> Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
> ---
> .../drm/i915/display/intel_display_types.h | 7 ++
> drivers/gpu/drm/i915/display/intel_dmc_regs.h | 71 +++++++++++++++++++
> drivers/gpu/drm/i915/display/intel_vrr.c | 29 ++++++++
> drivers/gpu/drm/i915/display/intel_vrr_regs.h | 10 +++
> 4 files changed, 117 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> index 94468a9d2e0d..126d54e6a393 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -1307,6 +1307,13 @@ struct intel_crtc_state {
> u8 pipeline_full;
> u16 flipline, vmin, vmax, guardband;
> u32 vsync_end, vsync_start;
> + struct {
> + bool enable;
> + u16 vmin, vmax;
> + u16 guardband, slope;
> + u16 max_increase, max_decrease;
> + u16 vblank_target;
> + } dc_balance;
> } vrr;
>
> /* Content Match Refresh Rate state */
> diff --git a/drivers/gpu/drm/i915/display/intel_dmc_regs.h b/drivers/gpu/drm/i915/display/intel_dmc_regs.h
> index 1bf446f96a10..39e4f70005ab 100644
> --- a/drivers/gpu/drm/i915/display/intel_dmc_regs.h
> +++ b/drivers/gpu/drm/i915/display/intel_dmc_regs.h
> @@ -103,4 +103,75 @@
> #define DMC_WAKELOCK_CTL_REQ REG_BIT(31)
> #define DMC_WAKELOCK_CTL_ACK REG_BIT(15)
>
> +#define _PIPEDMC_DCB_CTL_A 0x5F1A0
These are again added in Patch #9
> +#define _PIPEDMC_DCB_CTL_B 0x5F5A0
> +#define _PIPEDMC_DCB_CTL_C 0x5F9A0
> +#define _PIPEDMC_DCB_CTL_D 0x5FDA0
> +#define _PIPEDMC_DCB_CTL_E 0x551A0
> +#define _PIPEDMC_DCB_CTL_F 0x555A0
> +#define PIPEDMC_DCB_CTL(dev_priv, trans) _MMIO_TRANS2(dev_priv, trans, _PIPEDMC_DCB_CTL_A)
> +#define PIPEDMC_ADAPTIVE_DCB_ENABLE REG_BIT(31)
> +
> +#define _PIPEDMC_DCB_VBLANK_A 0x5F1BC
> +#define _PIPEDMC_DCB_VBLANK_B 0x5F5BC
> +#define _PIPEDMC_DCB_VBLANK_C 0x5F9BC
> +#define _PIPEDMC_DCB_VBLANK_D 0x5FDBC
> +#define _PIPEDMC_DCB_VBLANK_E 0x551BC
> +#define _PIPEDMC_DCB_VBLANK_F 0x555BC
> +#define PIPEDMC_DCB_VBLANK(dev_priv, trans) _MMIO_TRANS2(dev_priv, trans, _PIPEDMC_DCB_VBLANK_A)
> +
> +#define _PIPEDMC_DCB_SLOPE_A 0x5F1B8
> +#define _PIPEDMC_DCB_SLOPE_B 0x5F5B8
> +#define _PIPEDMC_DCB_SLOPE_C 0x5F9B8
> +#define _PIPEDMC_DCB_SLOPE_D 0x5FDB8
> +#define _PIPEDMC_DCB_SLOPE_E 0x551B8
> +#define _PIPEDMC_DCB_SLOPE_F 0x555B8
> +#define PIPEDMC_DCB_SLOPE(dev_priv, trans) _MMIO_TRANS2(dev_priv, trans, _PIPEDMC_DCB_SLOPE_A)
> +
> +#define _PIPEDMC_DCB_GUARDBAND_A 0x5F1B4
> +#define _PIPEDMC_DCB_GUARDBAND_B 0x5F5B4
> +#define _PIPEDMC_DCB_GUARDBAND_C 0x5F9B4
> +#define _PIPEDMC_DCB_GUARDBAND_D 0x5FDB4
> +#define _PIPEDMC_DCB_GUARDBAND_E 0x551B4
> +#define _PIPEDMC_DCB_GUARDBAND_F 0x555B4
> +#define PIPEDMC_DCB_GUARDBAND(dev_priv, trans) _MMIO_TRANS2(dev_priv, \
> + trans, \
> + _PIPEDMC_DCB_GUARDBAND_A)
> +
> +#define _PIPEDMC_DCB_MAX_INCREASE_A 0x5F1AC
> +#define _PIPEDMC_DCB_MAX_INCREASE_B 0x5F5AC
> +#define _PIPEDMC_DCB_MAX_INCREASE_C 0x5F9AC
> +#define _PIPEDMC_DCB_MAX_INCREASE_D 0x5FDAC
> +#define _PIPEDMC_DCB_MAX_INCREASE_E 0x551AC
> +#define _PIPEDMC_DCB_MAX_INCREASE_F 0x555AC
> +#define PIPEDMC_DCB_MAX_INCREASE(dev_priv, trans) _MMIO_TRANS2(dev_priv, \
> + trans, \
> + _PIPEDMC_DCB_MAX_INCREASE_A)
> +
> +#define _PIPEDMC_DCB_MAX_DECREASE_A 0x5F1B0
> +#define _PIPEDMC_DCB_MAX_DECREASE_B 0x5F5B0
> +#define _PIPEDMC_DCB_MAX_DECREASE_C 0x5F9B0
> +#define _PIPEDMC_DCB_MAX_DECREASE_D 0x5FDB0
> +#define _PIPEDMC_DCB_MAX_DECREASE_E 0x551B0
> +#define _PIPEDMC_DCB_MAX_DECREASE_F 0x555B0
> +#define PIPEDMC_DCB_MAX_DECREASE(dev_priv, trans) _MMIO_TRANS2(dev_priv, \
> + trans, \
> + _PIPEDMC_DCB_MAX_DECREASE_A)
> +
> +#define _PIPEDMC_DCB_VMIN_A 0x5F1A4
> +#define _PIPEDMC_DCB_VMIN_B 0x5F5A4
> +#define _PIPEDMC_DCB_VMIN_C 0x5F9A4
> +#define _PIPEDMC_DCB_VMIN_D 0x5FDA4
> +#define _PIPEDMC_DCB_VMIN_E 0x551A4
> +#define _PIPEDMC_DCB_VMIN_F 0x555A4
> +#define PIPEDMC_DCB_VMIN(dev_priv, trans) _MMIO_TRANS2(dev_priv, trans, _PIPEDMC_DCB_VMIN_A)
> +
> +#define _PIPEDMC_DCB_VMAX_A 0x5F1A8
> +#define _PIPEDMC_DCB_VMAX_B 0x5F5A8
> +#define _PIPEDMC_DCB_VMAX_C 0x5F9A8
> +#define _PIPEDMC_DCB_VMAX_D 0x5FDA8
> +#define _PIPEDMC_DCB_VMAX_E 0x551A8
> +#define _PIPEDMC_DCB_VMAX_F 0x555A8
> +#define PIPEDMC_DCB_VMAX(dev_priv, trans) _MMIO_TRANS2(dev_priv, trans, _PIPEDMC_DCB_VMAX_A)
> +
> #endif /* __INTEL_DMC_REGS_H__ */
> diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
> index 1c0eaa08927b..c4fb78d86ab0 100644
> --- a/drivers/gpu/drm/i915/display/intel_vrr.c
> +++ b/drivers/gpu/drm/i915/display/intel_vrr.c
> @@ -10,6 +10,7 @@
> #include "intel_de.h"
> #include "intel_display_types.h"
> #include "intel_dp.h"
> +#include "intel_dmc_regs.h"
> #include "intel_vrr.h"
> #include "intel_vrr_regs.h"
>
> @@ -601,6 +602,23 @@ void intel_vrr_enable(const struct intel_crtc_state *crtc_state)
> VRR_CTL_VRR_ENABLE | trans_vrr_ctl(crtc_state));
> }
> }
> +
> + if (crtc_state->vrr.dc_balance.enable && HAS_DC_BALANCE(display)) {
> + intel_de_write(display, PIPEDMC_DCB_VMIN(display, cpu_transcoder),
> + crtc_state->vrr.dc_balance.vmin - 1);
> + intel_de_write(display, PIPEDMC_DCB_VMAX(display, cpu_transcoder),
> + crtc_state->vrr.dc_balance.vmax - 1);
> + intel_de_write(display, PIPEDMC_DCB_MAX_INCREASE(display, cpu_transcoder),
> + crtc_state->vrr.dc_balance.max_increase);
> + intel_de_write(display, PIPEDMC_DCB_MAX_DECREASE(display, cpu_transcoder),
> + crtc_state->vrr.dc_balance.max_decrease);
> + intel_de_write(display, PIPEDMC_DCB_GUARDBAND(display, cpu_transcoder),
> + crtc_state->vrr.dc_balance.guardband);
> + intel_de_write(display, PIPEDMC_DCB_SLOPE(display, cpu_transcoder),
> + crtc_state->vrr.dc_balance.slope);
> + intel_de_write(display, PIPEDMC_DCB_VBLANK(display, cpu_transcoder),
> + crtc_state->vrr.dc_balance.vblank_target);
> + }
> }
>
> void intel_vrr_disable(const struct intel_crtc_state *old_crtc_state)
> @@ -611,6 +629,17 @@ void intel_vrr_disable(const struct intel_crtc_state *old_crtc_state)
> if (!old_crtc_state->vrr.enable)
> return;
>
> + if (old_crtc_state->vrr.dc_balance.enable && HAS_DC_BALANCE(display)) {
> + intel_de_write(display, TRANS_ADAPTIVE_SYNC_DCB_CTL(display, cpu_transcoder), 0);
> + intel_de_write(display, PIPEDMC_DCB_VMIN(display, cpu_transcoder), 0);
> + intel_de_write(display, PIPEDMC_DCB_VMAX(display, cpu_transcoder), 0);
> + intel_de_write(display, PIPEDMC_DCB_MAX_INCREASE(display, cpu_transcoder), 0);
> + intel_de_write(display, PIPEDMC_DCB_MAX_DECREASE(display, cpu_transcoder), 0);
> + intel_de_write(display, PIPEDMC_DCB_GUARDBAND(display, cpu_transcoder), 0);
> + intel_de_write(display, PIPEDMC_DCB_SLOPE(display, cpu_transcoder), 0);
> + intel_de_write(display, PIPEDMC_DCB_VBLANK(display, cpu_transcoder), 0);
> + }
> +
> if (!intel_vrr_always_use_vrr_tg(display)) {
> intel_de_write(display, TRANS_VRR_CTL(display, cpu_transcoder),
> trans_vrr_ctl(old_crtc_state));
> diff --git a/drivers/gpu/drm/i915/display/intel_vrr_regs.h b/drivers/gpu/drm/i915/display/intel_vrr_regs.h
> index 2214c10d4084..2db477325c83 100644
> --- a/drivers/gpu/drm/i915/display/intel_vrr_regs.h
> +++ b/drivers/gpu/drm/i915/display/intel_vrr_regs.h
> @@ -53,6 +53,16 @@
> #define VRR_FLIPLINE_DCB_MASK REG_GENMASK(19, 0)
> #define VRR_VMAX_DCB_MASK REG_GENMASK(19, 0)
>
> +#define _TRANS_ADAPTIVE_SYNC_DCB_CTL_A 0x604C0
These are again added in Patch#10.
I think lets have a separate patch where new members are introduced.
Regards,
Ankit
> +#define _TRANS_ADAPTIVE_SYNC_DCB_CTL_B 0x614C0
> +#define _TRANS_ADAPTIVE_SYNC_DCB_CTL_C 0x624C0
> +#define _TRANS_ADAPTIVE_SYNC_DCB_CTL_D 0x634C0
> +#define _TRANS_ADAPTIVE_SYNC_DCB_CTL_E 0x6B4C0
> +#define _TRANS_ADAPTIVE_SYNC_DCB_CTL_F 0x6C4C0
> +#define TRANS_ADAPTIVE_SYNC_DCB_CTL(dev_priv, trans) _MMIO_TRANS2(dev_priv, \
> + trans, \
> + _TRANS_ADAPTIVE_SYNC_DCB_CTL_A)
> +
> #define _TRANS_VRR_CTL_A 0x60420
> #define _TRANS_VRR_CTL_B 0x61420
> #define _TRANS_VRR_CTL_C 0x62420
next prev parent reply other threads:[~2025-04-23 7:02 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 15:48 [PATCH v2 00/13] Enable/Disable DC balance along with VRR DSB Mitul Golani
2025-04-21 15:48 ` [PATCH v2 01/13] drm/i915/vrr: Refactor vmin/vmax stuff Mitul Golani
2025-04-23 6:49 ` Nautiyal, Ankit K
2025-04-25 11:36 ` Nautiyal, Ankit K
2025-04-21 15:48 ` [PATCH v2 02/13] drm/i915/vrr: Add functions to read out " Mitul Golani
2025-04-23 6:52 ` Nautiyal, Ankit K
2025-04-23 13:17 ` Nautiyal, Ankit K
2025-04-23 13:34 ` Nautiyal, Ankit K
2025-04-21 15:48 ` [PATCH v2 03/13] drm/i915/display: Add source param for dc balance Mitul Golani
2025-04-23 6:58 ` Nautiyal, Ankit K
2025-04-21 15:48 ` [PATCH v2 04/13] drm/i915/vrr: Add enable/disable calls for DC Balance Mitul Golani
2025-04-23 7:01 ` Nautiyal, Ankit K [this message]
2025-04-21 15:48 ` [PATCH v2 05/13] drm/i915/vrr: Add compute config for DC balance params Mitul Golani
2025-04-23 7:05 ` Nautiyal, Ankit K
2025-04-21 15:48 ` [PATCH v2 06/13] drm/i915/vrr: Add state dump for dc " Mitul Golani
2025-04-23 8:47 ` Nautiyal, Ankit K
2025-04-21 15:48 ` [PATCH v2 07/13] drm/i915: Extract vrr_vblank_start() Mitul Golani
2025-04-23 7:10 ` Nautiyal, Ankit K
2025-04-21 15:48 ` [PATCH v2 08/13] drm/i915/vrr: Implement vblank evasion with DC balancing Mitul Golani
2025-04-23 7:15 ` Nautiyal, Ankit K
2025-04-21 15:48 ` [PATCH v2 09/13] drm/i915/dsb: Add pipedmc dc balance enable/disable Mitul Golani
2025-04-23 7:16 ` Nautiyal, Ankit K
2025-04-21 15:48 ` [PATCH v2 10/13] drm/i915/vrr: Pause DC balancing for DSB commits Mitul Golani
2025-04-23 7:21 ` Nautiyal, Ankit K
2025-04-21 15:48 ` [PATCH v2 11/13] drm/i915/vrr: Add state checker for dc balance params Mitul Golani
2025-04-23 7:24 ` Nautiyal, Ankit K
2025-04-23 10:21 ` Jani Nikula
2025-04-23 11:36 ` Nautiyal, Ankit K
2025-04-21 15:48 ` [PATCH v2 12/13] drm/i915/display: Prepare state checker for dc balance enable Mitul Golani
2025-04-23 7:26 ` Nautiyal, Ankit K
2025-04-21 15:49 ` [PATCH v2 13/13] drm/i915/vrr: enable dc balance bit Mitul Golani
2025-04-23 7:28 ` Nautiyal, Ankit K
2025-04-21 16:43 ` ✓ CI.Patch_applied: success for Enable/Disable DC balance along with VRR DSB Patchwork
2025-04-21 16:44 ` ✓ CI.checkpatch: " Patchwork
2025-04-21 16:45 ` ✓ CI.KUnit: " Patchwork
2025-04-21 16:53 ` ✓ CI.Build: " Patchwork
2025-04-21 16:55 ` ✓ CI.Hooks: " Patchwork
2025-04-21 16:57 ` ✗ CI.checksparse: warning " Patchwork
2025-04-21 18:39 ` ✗ Xe.CI.Full: failure " Patchwork
2025-04-22 13:19 ` ✓ Xe.CI.BAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0abc19ec-ff48-4a2c-b347-598fba194bca@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=mitulkumar.ajitkumar.golani@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox