From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Sebinraj, S" <s.sebinraj@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>
Cc: "Badrappan, Jeevaka" <jeevaka.badrappan@intel.com>
Subject: RE: [PATCH v3 3/3] drm/xe: Refactoring the code as per review comment
Date: Wed, 17 Sep 2025 10:23:11 +0300 [thread overview]
Message-ID: <0c44364d65dc0155fd2c2da1d413160241cca767@intel.com> (raw)
In-Reply-To: <CH0PR11MB542770B0F746BE12B3E8461E9817A@CH0PR11MB5427.namprd11.prod.outlook.com>
On Wed, 17 Sep 2025, "Sebinraj, S" <s.sebinraj@intel.com> wrote:
> On Tue, 16 Sep 2025, S Sebinraj <s.sebinraj@intel.com> wrote:
>> Moved the trace file header to appropriate path "include/drm" and
>> updated the code as per the same.
>
>> You're not supposed to address code review in independent patches but rather modify the original patches. This is kernel development basics.
>
>> BR,
>> Jani.
>
> Okay got it, so now do I need to go back and make the changes in original patch and then raise again or this would be fine for now ?
> Please let me know.
You need to post the revised patches. 'git rebase -i' is your friend
here.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2025-09-17 7:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 7:27 [PATCH v3 0/3] drm: Add GPU frequency tracepoint S Sebinraj
2025-09-16 7:27 ` [PATCH v3 1/3] drm: Add GPU frequency tracepoint at DRM level S Sebinraj
2025-09-16 7:27 ` [PATCH v3 2/3] drm/xe: Add DRM GPU frequency tracepoint to Xe S Sebinraj
2025-09-16 7:27 ` [PATCH v3 3/3] drm/xe: Refactoring the code as per review comment S Sebinraj
2025-09-16 8:56 ` Jani Nikula
2025-09-17 4:14 ` Sebinraj, S
2025-09-17 7:23 ` Jani Nikula [this message]
2025-09-16 8:15 ` ✗ CI.checkpatch: warning for drm: Add GPU frequency tracepoint (rev2) Patchwork
2025-09-16 8:16 ` ✓ CI.KUnit: success " Patchwork
2025-09-16 8:52 ` ✓ Xe.CI.BAT: " Patchwork
2025-09-16 11:05 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c44364d65dc0155fd2c2da1d413160241cca767@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jeevaka.badrappan@intel.com \
--cc=s.sebinraj@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox