Re: [Intel-xe] [PATCH v4 2/2] drm/xe/pmu: Enable PMU interface

["Iddamsetty, Aravind" <aravind.iddamsetty@intel.com>]

On 14-08-2023 22:41, Dixit, Ashutosh wrote:
> On Mon, 14 Aug 2023 06:12:13 -0700, Aravind Iddamsetty wrote:
>>
> 
> Hi Aravind,
> 
> So I am not going to review this version of the patch. Let's do it as was
> discussed today, I am assuming something like: when the event is "opened"
> do a xe_device_mem_access_get and forcewake_get from some non-atomic
> context. And keep these references till the event is "closed". Also since
> we are keeping the device awake through PMU data collection, no need to
> cache register values during rpm_suspend?

Hi Ashutosh,

I was thinking of a  two stage effort, first have this series merged in
the current form and extend it in the later, please let me know if you
think otherwise.

yes we still need to cache registers during suspend as that can happen
even when PMU is not opened and also PMU can be opened when in suspend
and we have to return the cached value.

We shall only take forcewake when any event is opened and when the
device is awake.

Thanks,
Aravind.
> 
> Thanks.
> --
> Ashutosh