Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
Cc: Bommu Krishnaiah <krishnaiah.bommu@intel.com>,
	intel-xe@lists.freedesktop.org,
	Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [Intel-xe] [PATCH v4 2/2] drm/xe/pmu: Enable PMU interface
Date: Mon, 14 Aug 2023 10:11:36 -0700	[thread overview]
Message-ID: <875y5htupj.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20230814131213.1620252-3-aravind.iddamsetty@intel.com>

On Mon, 14 Aug 2023 06:12:13 -0700, Aravind Iddamsetty wrote:
>

Hi Aravind,

So I am not going to review this version of the patch. Let's do it as was
discussed today, I am assuming something like: when the event is "opened"
do a xe_device_mem_access_get and forcewake_get from some non-atomic
context. And keep these references till the event is "closed". Also since
we are keeping the device awake through PMU data collection, no need to
cache register values during rpm_suspend?

Thanks.
--
Ashutosh

  reply	other threads:[~2023-08-14 17:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-14 13:12 [Intel-xe] [PATCH v4 0/2] drm/xe/pmu: Enable PMU interface Aravind Iddamsetty
2023-08-14 13:10 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe/pmu: Enable PMU interface (rev4) Patchwork
2023-08-14 13:10 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-08-14 13:11 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-08-14 13:12 ` [Intel-xe] [PATCH v3 1/2] drm/xe: Get GT clock to nanosecs Aravind Iddamsetty
2023-08-14 13:12 ` [Intel-xe] [PATCH v4 2/2] drm/xe/pmu: Enable PMU interface Aravind Iddamsetty
2023-08-14 17:11   ` Dixit, Ashutosh [this message]
2023-08-16  5:48     ` Iddamsetty, Aravind
2023-08-14 13:15 ` [Intel-xe] ✓ CI.Build: success for drm/xe/pmu: Enable PMU interface (rev4) Patchwork
2023-08-14 13:16 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-08-14 13:16 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-08-14 13:53 ` [Intel-xe] ○ CI.BAT: info " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875y5htupj.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=aravind.iddamsetty@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=krishnaiah.bommu@intel.com \
    --cc=tvrtko.ursulin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox