Re: [PATCH 1/2] drm/xe/gsc: Define GSC for NVL-P

["Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>]

On Thu, 2026-09-17 at 22:40 +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] xe: GSC firmware loading fails for NOVALAKE_P due to array ordering
> --
alan:[snip]
> [Severity: High]
> Will inserting NOVALAKE_P here cause the firmware selection loop to fail?
> 
> Looking at uc_fw_auto_select() in drivers/gpu/drm/xe/xe_uc_fw.c, the loop
> termination condition expects the entries array to be sorted strictly
> descending by platform enum:
> 
> 	for (i = 0; i < count && p <= entries[i].platform; i++) {
> 		...
> 	}
> 
> Since XE_NOVALAKE_P (enum value 15) is greater than the first entry
> XE_PANTHERLAKE (enum value 12), the condition (15 <= 12) evaluates to false
> on the very first iteration when trying to load firmware for NOVALAKE_P.
> 
> This aborts the search immediately, leaving uc_fw->path as NULL and failing
> to load the GSC firmware.
> 
> >  	fw_def(LUNARLAKE,	GT_TYPE_ANY,	major_ver(xe,	gsc,	lnl,	104, 1, 0))	\
> >  	fw_def(METEORLAKE,	GT_TYPE_ANY,	major_ver(i915,	gsc,	mtl,	102, 1, 0))
> 
This is a valid bug. Will re-rev.