Re: [PATCH v5 7/7] drm/xe/sysctrl: Report 'System Controller event' error using SIGID

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 8/25/2026 1:05 PM, Mallesh Koujalagi wrote:
> Report 'System Controller event' error using xe_log() helpers.
> 
> Signed-off-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
> ---
> v5:
> - Change Error as EXFULL. (Michal)
> - Update logging message.
> ---
>  drivers/gpu/drm/xe/xe_sysctrl_event.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_sysctrl_event.c b/drivers/gpu/drm/xe/xe_sysctrl_event.c
> index da395148ee9d..7a3aa0aad6a3 100644
> --- a/drivers/gpu/drm/xe/xe_sysctrl_event.c
> +++ b/drivers/gpu/drm/xe/xe_sysctrl_event.c
> @@ -5,6 +5,7 @@
>  
>  #include "xe_device.h"
>  #include "xe_irq.h"
> +#include "xe_log.h"
>  #include "xe_printk.h"
>  #include "xe_ras.h"
>  #include "xe_sysctrl.h"
> @@ -25,23 +26,26 @@ static void get_pending_event(struct xe_sysctrl *sc, struct xe_sysctrl_mailbox_c
>  
>  		ret = xe_sysctrl_send_command(sc, command, &len);
>  		if (ret) {
> -			xe_err(xe, "sysctrl: failed to get pending event %d\n", ret);
> +			xe_log_err(xe, SYSCTRL, ret, "Failed to get pending event\n");
>  			return;
>  		}
>  
>  		if (len != sizeof(*response)) {
> -			xe_err(xe, "sysctrl: unexpected event response length %zu (expected %zu)\n",
> -			       len, sizeof(*response));
> +			xe_log_err(xe, SYSCTRL, -EMSGSIZE,

nit: maybe this should be -EPROTO (as it breaks ABI protocol)

> +				   "Unexpected event response length %zu (expected %zu)\n",
> +				   len, sizeof(*response));
>  			return;
>  		}
>  
>  		if (response->event == XE_SYSCTRL_EVENT_THRESHOLD_CROSSED)
>  			xe_ras_counter_threshold_crossed(xe, response);
>  		else
> -			xe_warn(xe, "sysctrl: unexpected event %#x\n", response->event);
> +			xe_log_err_info(xe, SYSCTRL, -EPROTO,

and then this one should be -ENOPKG as maybe this is just our missing
implementation for some valid future event type?
> +					"Unexpected event %#x\n", response->event);
>  
>  		if (!--count) {
> -			xe_err(xe, "sysctrl: event flooding\n");
> +			xe_log_err(xe, SYSCTRL, -EXFULL,
> +				   "Ignored %u events due to flooding\n", response->count);
>  			return;
>  		}
>  

anyway,

Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>