Re: [PATCH v5 7/7] drm/xe/sysctrl: Report 'System Controller event' error using SIGID

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch includes a nonexistent header `xe_log.h` and references undefined logging macros, breaking the build.
--

--- Patch [7]: [PATCH v5 7/7] drm/xe/sysctrl: Report 'System Controller event' error using SIGID ---
commit 5dd0dcae7a92f1eec8f1bdc6337685ee71b3e2e4
Author: Mallesh Koujalagi <mallesh.koujalagi@intel.com>

drm/xe/sysctrl: Report 'System Controller event' error using SIGID

This patch updates the error logging in xe_sysctrl_event.c to use the
xe_log() helpers for system controller events.

> diff --git a/drivers/gpu/drm/xe/xe_sysctrl_event.c b/drivers/gpu/drm/xe/xe_sysctrl_event.c
> index da395148ee9dc..7a3aa0aad6a35 100644
> --- a/drivers/gpu/drm/xe/xe_sysctrl_event.c
> +++ b/drivers/gpu/drm/xe/xe_sysctrl_event.c
> @@ -5,6 +5,7 @@
>  
>  #include "xe_device.h"
>  #include "xe_irq.h"
> +#include "xe_log.h"

[Severity: Low]
Does this header file exist? It seems the include of xe_log.h and the
subsequent uses of xe_log_err() and SYSCTRL in get_pending_event() will
cause a build failure. Was the patch adding this header and the logging
macros accidentally omitted from this series?

[ ... ]

> @@ -25,23 +26,26 @@ static void get_pending_event(struct xe_sysctrl *sc, struct xe_sysctrl_mailbox_c
>  
>  		ret = xe_sysctrl_send_command(sc, command, &len);
>  		if (ret) {
> -			xe_err(xe, "sysctrl: failed to get pending event %d\n", ret);
> +			xe_log_err(xe, SYSCTRL, ret, "Failed to get pending event\n");
>  			return;
>  		}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260825110542.1359776-9-mallesh.koujalagi@intel.com?part=7