Re: [PATCH v2 2/4] drm/xe/guc: Introduce GUC_FIRMWARE_VER_AT_LEAST helper

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 12/15/2025 3:37 PM, Michal Wajdeczko wrote:
> There are already few places in the code where we need to check GuC
> firmware version. Wrap existing raw conditions into a named helper
> macro to make it clear and avoid explicit call of the MAKE_GUC_VER.
> 
> Suggested-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> ---
> v1: split from [1] (Michal)
>     rename helper and add new macro (Daniele)
> 
> [1] https://patchwork.freedesktop.org/patch/693953/?series=158874&rev=1
> ---
> note: there is yet another place that could be updated (xe_guc.c)
>       but since it seems already broken (VFs don't know FW version)
>       it should be fixed separately anyway.

posted [2] fix for this other usage

[2] https://patchwork.freedesktop.org/series/159040/#rev1