Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: cancel pending job timer before freeing scheduler
@ 2025-02-24 12:22 Tejas Upadhyay
  2025-02-24 14:28 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: Tejas Upadhyay @ 2025-02-24 12:22 UTC (permalink / raw)
  To: intel-xe; +Cc: matthew.brost, Tejas Upadhyay

Async call to __guc_exec_queue_fini_async frees scheduler
at the same time when some scheduler submission would have
timed out and restarted. To handle such small window race
case, all pending jobs timer should be cancelled before
freeing scheduler.

It will help to solve below which is not easily reproducible,
https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/4223

V2(MattB):
 - Cancel pending jobs before scheduler finish

Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_submit.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index f2ce3086838c..8b7165d3820b 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -1258,6 +1258,8 @@ static void __guc_exec_queue_fini_async(struct work_struct *w)
 		cancel_work_sync(&ge->lr_tdr);
 	release_guc_id(guc, q);
 	xe_sched_entity_fini(&ge->entity);
+	/* Confirm no work left behind accessing device structures */
+	cancel_delayed_work_sync(&ge->sched.base.work_tdr);
 	xe_sched_fini(&ge->sched);
 
 	kfree(ge);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2025-02-24 16:26 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-24 12:22 [PATCH] drm/xe: cancel pending job timer before freeing scheduler Tejas Upadhyay
2025-02-24 14:28 ` ✓ CI.Patch_applied: success for " Patchwork
2025-02-24 14:28 ` ✓ CI.checkpatch: " Patchwork
2025-02-24 14:30 ` ✓ CI.KUnit: " Patchwork
2025-02-24 14:46 ` ✓ CI.Build: " Patchwork
2025-02-24 14:48 ` ✓ CI.Hooks: " Patchwork
2025-02-24 14:50 ` ✓ CI.checksparse: " Patchwork
2025-02-24 14:51 ` [PATCH] " Matthew Brost
2025-02-24 15:10 ` ✗ Xe.CI.BAT: failure for " Patchwork
2025-02-24 16:26 ` ✗ Xe.CI.Full: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox