Re: [PATCH v2 1/7] drm/i915/hdmi: use intel_de_wait_for_set() instead of wait_for()

[Gustavo Sousa <gustavo.sousa@intel.com>]

Quoting Jani Nikula (2025-07-31 07:05:08-03:00)
>Prefer the register read specific wait function over i915 wait_for().
>
>Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>

>---
> drivers/gpu/drm/i915/display/intel_hdmi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
>index 03045d188817..cbee628eb26b 100644
>--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
>+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
>@@ -1582,9 +1582,9 @@ bool intel_hdmi_hdcp_check_link_once(struct intel_digital_port *dig_port,
>         intel_de_write(display, HDCP_RPRIME(display, cpu_transcoder, port), ri.reg);
> 
>         /* Wait for Ri prime match */
>-        if (wait_for((intel_de_read(display, HDCP_STATUS(display, cpu_transcoder, port)) &
>-                      (HDCP_STATUS_RI_MATCH | HDCP_STATUS_ENC)) ==
>-                     (HDCP_STATUS_RI_MATCH | HDCP_STATUS_ENC), 1)) {
>+        ret = intel_de_wait_for_set(display, HDCP_STATUS(display, cpu_transcoder, port),
>+                                    HDCP_STATUS_RI_MATCH | HDCP_STATUS_ENC, 1);
>+        if (ret) {
>                 drm_dbg_kms(display->drm, "Ri' mismatch detected (%x)\n",
>                             intel_de_read(display, HDCP_STATUS(display, cpu_transcoder,
>                                                                port)));
>-- 
>2.39.5
>