Re: [PATCH v2 6/7] drm/i915/pch: use intel_de_wait_custom() instead of wait_for_us()

[Gustavo Sousa <gustavo.sousa@intel.com>]

Quoting Jani Nikula (2025-07-31 07:05:13-03:00)
>Prefer the register read specific wait function over i915 wait_for_us().
>
>Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>

>---
> drivers/gpu/drm/i915/display/intel_pch_refclk.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_pch_refclk.c b/drivers/gpu/drm/i915/display/intel_pch_refclk.c
>index d3c5255bf1a8..9ae53679a041 100644
>--- a/drivers/gpu/drm/i915/display/intel_pch_refclk.c
>+++ b/drivers/gpu/drm/i915/display/intel_pch_refclk.c
>@@ -17,16 +17,22 @@
> 
> static void lpt_fdi_reset_mphy(struct intel_display *display)
> {
>+        int ret;
>+
>         intel_de_rmw(display, SOUTH_CHICKEN2, 0, FDI_MPHY_IOSFSB_RESET_CTL);
> 
>-        if (wait_for_us(intel_de_read(display, SOUTH_CHICKEN2) &
>-                        FDI_MPHY_IOSFSB_RESET_STATUS, 100))
>+        ret = intel_de_wait_custom(display, SOUTH_CHICKEN2,
>+                                   FDI_MPHY_IOSFSB_RESET_STATUS, FDI_MPHY_IOSFSB_RESET_STATUS,
>+                                   100, 0, NULL);
>+        if (ret)
>                 drm_err(display->drm, "FDI mPHY reset assert timeout\n");
> 
>         intel_de_rmw(display, SOUTH_CHICKEN2, FDI_MPHY_IOSFSB_RESET_CTL, 0);
> 
>-        if (wait_for_us((intel_de_read(display, SOUTH_CHICKEN2) &
>-                         FDI_MPHY_IOSFSB_RESET_STATUS) == 0, 100))
>+        ret = intel_de_wait_custom(display, SOUTH_CHICKEN2,
>+                                   FDI_MPHY_IOSFSB_RESET_STATUS, 0,
>+                                   100, 0, NULL);
>+        if (ret)
>                 drm_err(display->drm, "FDI mPHY reset de-assert timeout\n");
> }
> 
>-- 
>2.39.5
>