Re: [PATCH v3 17/23] drm/xe: Bypass Wa_14018094691 when primary GT is disabled

[Gustavo Sousa <gustavo.sousa@intel.com>]

Quoting Matt Roper (2025-09-30 19:56:34-03:00)
>Don't try to lookup Wa_14018094691 on a NULL GT when the primary GT is
>disabled.  If the primary GT is disabled, there's no mid-thread
>preemption happening which would make this workaround relevant anyway.

s/relevant/irrelevant/?

>
>Signed-off-by: Matt Roper <matthew.d.roper@intel.com>

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>

>---
> drivers/gpu/drm/xe/xe_gsc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_gsc.c b/drivers/gpu/drm/xe/xe_gsc.c
>index 83d61bf8ec62..dd69cb834f8e 100644
>--- a/drivers/gpu/drm/xe/xe_gsc.c
>+++ b/drivers/gpu/drm/xe/xe_gsc.c
>@@ -266,7 +266,7 @@ static int gsc_upload_and_init(struct xe_gsc *gsc)
>         unsigned int fw_ref;
>         int ret;
> 
>-        if (XE_GT_WA(tile->primary_gt, 14018094691)) {
>+        if (tile->primary_gt && XE_GT_WA(tile->primary_gt, 14018094691)) {
>                 fw_ref = xe_force_wake_get(gt_to_fw(tile->primary_gt), XE_FORCEWAKE_ALL);
> 
>                 /*
>@@ -281,7 +281,7 @@ static int gsc_upload_and_init(struct xe_gsc *gsc)
> 
>         ret = gsc_upload(gsc);
> 
>-        if (XE_GT_WA(tile->primary_gt, 14018094691))
>+        if (tile->primary_gt && XE_GT_WA(tile->primary_gt, 14018094691))
>                 xe_force_wake_put(gt_to_fw(tile->primary_gt), fw_ref);
> 
>         if (ret)
>-- 
>2.51.0
>