Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Sousa <gustavo.sousa@intel.com>
To: Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
	<intel-xe@lists.freedesktop.org>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
	Matt Roper <matthew.d.roper@intel.com>
Subject: Re: [PATCH] drm/xe: put COMMON_SLICE_CHICKEN3 on the allowlist for UMD
Date: Mon, 5 Jan 2026 15:54:23 -0300	[thread overview]
Message-ID: <176763926313.9480.16817172111730313247@intel.com> (raw)
In-Reply-To: <20260105150222.462293-1-lionel.g.landwerlin@intel.com>

Quoting Lionel Landwerlin (2026-01-05 12:02:22-03:00)
>Similar to i915's commit cebc13de7e704b1355bea208a9f9cdb042c74588
>("drm/i915: Whitelist COMMON_SLICE_CHICKEN3 for UMD access")
>
>A recommended tuning setting for both gen12 and Xe_HP platforms
>requires that we grant userspace r/w access to the
>COMMON_SLICE_CHICKEN3 register.
>
>Bspec: 73993, 73994, 31870, 68331
>Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>---
> drivers/gpu/drm/xe/xe_reg_whitelist.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/drivers/gpu/drm/xe/xe_reg_whitelist.c b/drivers/gpu/drm/xe/xe_reg_whitelist.c
>index 1391cb6ec9c62..4dcbc42574bf5 100644
>--- a/drivers/gpu/drm/xe/xe_reg_whitelist.c
>+++ b/drivers/gpu/drm/xe/xe_reg_whitelist.c
>@@ -45,6 +45,11 @@ static const struct xe_rtp_entry_sr register_whitelist[] = {
>           XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1200, 1210), ENGINE_CLASS(RENDER)),
>           XE_RTP_ACTIONS(WHITELIST(COMMON_SLICE_CHICKEN1, 0))
>         },
>+        { XE_RTP_NAME("allow_common_slice_chicken3"),
>+          XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1200, XE_RTP_END_VERSION_UNDEFINED),

With XE_RTP_END_VERSION_UNDEFINED, this spans to any current and future
GT containig graphics version 12 or higher.  I believe we need to limit
this to 12.74.

--
Gustavo Sousa

>+                       ENGINE_CLASS(RENDER)),
>+          XE_RTP_ACTIONS(WHITELIST(COMMON_SLICE_CHICKEN3, 0))
>+        },
>         { XE_RTP_NAME("1806527549"),
>           XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1200, 1210), ENGINE_CLASS(RENDER)),
>           XE_RTP_ACTIONS(WHITELIST(HIZ_CHICKEN, 0))
>-- 
>2.43.0
>

  parent reply	other threads:[~2026-01-05 18:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-05 15:02 [PATCH] drm/xe: put COMMON_SLICE_CHICKEN3 on the allowlist for UMD Lionel Landwerlin
2026-01-05 15:06 ` ✗ CI.checkpatch: warning for " Patchwork
2026-01-05 15:07 ` ✓ CI.KUnit: success " Patchwork
2026-01-05 15:51 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-05 18:54 ` Gustavo Sousa [this message]
2026-01-05 20:04   ` [PATCH] " Lionel Landwerlin
2026-01-05 20:24     ` Matt Roper
2026-01-05 20:53       ` Lionel Landwerlin
2026-01-05 19:01 ` ✗ Xe.CI.Full: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176763926313.9480.16817172111730313247@intel.com \
    --to=gustavo.sousa@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lionel.g.landwerlin@intel.com \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox