Re: [PATCH] drm/xe/xe2hpg: Performance tuning changes

[Gustavo Sousa <gustavo.sousa@intel.com>]

Quoting Balasubramani Vivekanandan (2026-01-09 13:42:51-03:00)
>Further updates to performance tuning for Xe2_HPG

Maybe worth noting that this is specific for version 20.02 of the IP.

>
>Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
>---
> drivers/gpu/drm/xe/regs/xe_gt_regs.h | 3 +++
> drivers/gpu/drm/xe/xe_tuning.c       | 5 +++++
> 2 files changed, 8 insertions(+)
>
>diff --git a/drivers/gpu/drm/xe/regs/xe_gt_regs.h b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
>index 93643da57428..cc18ddfb7cc0 100644
>--- a/drivers/gpu/drm/xe/regs/xe_gt_regs.h
>+++ b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
>@@ -135,6 +135,9 @@
> 
> #define XEHPG_INSTDONE_GEOM_SVGUNIT                XE_REG_MCR(0x666c)
> 
>+#define CACHE_MODE_0                                XE_REG_MCR(0x7000, XE_REG_OPTION_MASKED)
>+#define   MSAA_FAST_CLEAR_ENABLED                REG_BIT(5)
>+
> #define CACHE_MODE_1                                XE_REG(0x7004, XE_REG_OPTION_MASKED)

Huh. A bit unrelated to this patch, but I find it weird that
CACHE_MODE_1 is not defined as multicast.

The current users of CACHE_MODE_1 are DG2 and MTL and that register is
multicast for both (Bspec 66534 and 67788).  We probably need a separate
patch to fix this.

Anyway,

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>

> #define   MSAA_OPTIMIZATION_REDUC_DISABLE        REG_BIT(11)
> 
>diff --git a/drivers/gpu/drm/xe/xe_tuning.c b/drivers/gpu/drm/xe/xe_tuning.c
>index 5766fa7742d3..122829c8d14e 100644
>--- a/drivers/gpu/drm/xe/xe_tuning.c
>+++ b/drivers/gpu/drm/xe/xe_tuning.c
>@@ -144,6 +144,11 @@ static const struct xe_rtp_entry_sr lrc_tunings[] = {
>           XE_RTP_ACTIONS(FIELD_SET(FF_MODE, VS_HIT_MAX_VALUE_MASK,
>                                    REG_FIELD_PREP(VS_HIT_MAX_VALUE_MASK, 0x3f)))
>         },
>+
>+        { XE_RTP_NAME("Tuning: MSAA fast clear"),
>+          XE_RTP_RULES(GRAPHICS_VERSION(2002), ENGINE_CLASS(RENDER)),
>+          XE_RTP_ACTIONS(SET(CACHE_MODE_0, MSAA_FAST_CLEAR_ENABLED))
>+        },
> };
> 
> /**
>-- 
>2.43.0
>