Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Vivekanandan, Balasubramani" <balasubramani.vivekanandan@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH] drm/xe/xe2hpg: Performance tuning changes
Date: Fri, 16 Jan 2026 13:37:16 +0530	[thread overview]
Message-ID: <aWnxtIjVvZObm1XE@bvivekan-mob1> (raw)
In-Reply-To: <20260113153426.GE458797@mdroper-desk1.amr.corp.intel.com>

On 13.01.2026 07:34, Matt Roper wrote:
> On Fri, Jan 09, 2026 at 10:12:51PM +0530, Balasubramani Vivekanandan wrote:
> > Further updates to performance tuning for Xe2_HPG
> > 
> > Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
> > ---
> >  drivers/gpu/drm/xe/regs/xe_gt_regs.h | 3 +++
> >  drivers/gpu/drm/xe/xe_tuning.c       | 5 +++++
> >  2 files changed, 8 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/xe/regs/xe_gt_regs.h b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> > index 93643da57428..cc18ddfb7cc0 100644
> > --- a/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> > +++ b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> > @@ -135,6 +135,9 @@
> >  
> >  #define XEHPG_INSTDONE_GEOM_SVGUNIT		XE_REG_MCR(0x666c)
> >  
> > +#define CACHE_MODE_0				XE_REG_MCR(0x7000, XE_REG_OPTION_MASKED)
> > +#define   MSAA_FAST_CLEAR_ENABLED		REG_BIT(5)
> 
> This register is under UMD control and Mesa is already applying the
> workaround on their side.  Is there a need to do this in the kernel?

I wasn't aware UMD is already applying this workaround. Thanks for
informing. We can then drop this patch.

Regards,
Bala

> 
> 
> Matt
> 
> > +
> >  #define CACHE_MODE_1				XE_REG(0x7004, XE_REG_OPTION_MASKED)
> >  #define   MSAA_OPTIMIZATION_REDUC_DISABLE	REG_BIT(11)
> >  
> > diff --git a/drivers/gpu/drm/xe/xe_tuning.c b/drivers/gpu/drm/xe/xe_tuning.c
> > index 5766fa7742d3..122829c8d14e 100644
> > --- a/drivers/gpu/drm/xe/xe_tuning.c
> > +++ b/drivers/gpu/drm/xe/xe_tuning.c
> > @@ -144,6 +144,11 @@ static const struct xe_rtp_entry_sr lrc_tunings[] = {
> >  	  XE_RTP_ACTIONS(FIELD_SET(FF_MODE, VS_HIT_MAX_VALUE_MASK,
> >  				   REG_FIELD_PREP(VS_HIT_MAX_VALUE_MASK, 0x3f)))
> >  	},
> > +
> > +	{ XE_RTP_NAME("Tuning: MSAA fast clear"),
> > +	  XE_RTP_RULES(GRAPHICS_VERSION(2002), ENGINE_CLASS(RENDER)),
> > +	  XE_RTP_ACTIONS(SET(CACHE_MODE_0, MSAA_FAST_CLEAR_ENABLED))
> > +	},
> >  };
> >  
> >  /**
> > -- 
> > 2.43.0
> > 
> 
> -- 
> Matt Roper
> Graphics Software Engineer
> Linux GPU Platform Enablement
> Intel Corporation

      reply	other threads:[~2026-01-16  8:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-09 16:42 [PATCH] drm/xe/xe2hpg: Performance tuning changes Balasubramani Vivekanandan
2026-01-09 17:07 ` ✓ CI.KUnit: success for " Patchwork
2026-01-09 17:40 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-09 19:37 ` [PATCH] " Gustavo Sousa
2026-01-09 22:45 ` ✗ Xe.CI.Full: failure for " Patchwork
2026-01-12  7:04 ` ✓ CI.KUnit: success for drm/xe/xe2hpg: Performance tuning changes (rev2) Patchwork
2026-01-12  7:40 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-12  8:45 ` ✗ Xe.CI.Full: failure " Patchwork
2026-01-13 15:34 ` [PATCH] drm/xe/xe2hpg: Performance tuning changes Matt Roper
2026-01-16  8:07   ` Vivekanandan, Balasubramani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWnxtIjVvZObm1XE@bvivekan-mob1 \
    --to=balasubramani.vivekanandan@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox